Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: handle charm status only from CollectStatus event callback #174

Merged
merged 1 commit into from
Apr 24, 2024

Conversation

dariofaccin
Copy link
Contributor

Description

This PR aims to fix #173. Status setting is removed from the try-except block during __init__ and it now relies only on the CollectStatus event callback.
Unit tests requiring charm reinstatiation, as updated by #147, are updated evaluating the unit status.

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • I have added tests that validate the behaviour of the software
  • I validated that new and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have bumped the version of the library

@dariofaccin dariofaccin requested a review from a team as a code owner April 24, 2024 12:50
@dariofaccin dariofaccin merged commit de40430 into main Apr 24, 2024
28 checks passed
@dariofaccin dariofaccin deleted the TELCO-1208-fix-status-handling branch April 24, 2024 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Charm sets status from init instead of relying on CollectStatus event
3 participants