Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fixes Unauthorized error when listing K8s nodes #458

Merged
merged 1 commit into from
Jan 10, 2025

Conversation

Gmerold
Copy link
Contributor

@Gmerold Gmerold commented Jan 9, 2025

Description

When kube-apiserver isn't ready, fetching list of K8s nodes fails with Unauthorized error. This fix handles such situation by catching the error and logging the relevant message rather than raising an error which puts the charm in the error state.

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • I have added tests that validate the behaviour of the software
  • I validated that new and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have bumped the version of the library

@Gmerold Gmerold requested a review from a team as a code owner January 9, 2025 09:44
@Gmerold Gmerold merged commit ffa4042 into main Jan 10, 2025
16 checks passed
@Gmerold Gmerold deleted the TELCO-1543-fix-unauthorized branch January 10, 2025 10:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants