Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(remotebuild): parse '--build-for' and '--platform' #4994

Merged
merged 2 commits into from
Aug 23, 2024

Conversation

mr-cal
Copy link
Collaborator

@mr-cal mr-cal commented Aug 21, 2024

  • Have you followed the guidelines for contributing?
  • Have you signed the CLA?
  • Have you successfully run tox run -m lint?
  • Have you successfully run tox run -e test-py310? (supported versions: py39, py310, py311, py312)

  • '--build-for' and '--platform' can only be used when 'platforms' and 'architectures' are not defined in the project metadata
  • '--platform' cannot be used for core22 snaps
  • Add links to documentation for remote-build errors
  • Update remote-build documentation

Creates #4992
Fixes #4858
Fixes #4881
(CRAFT-3070)

* '--build-for' and '--platform' can only be used when 'platforms' and
  'architectures' are not defined in the project metadata
* '--platform' cannot be used for core22 snaps

Signed-off-by: Callahan Kovacs <callahan.kovacs@canonical.com>
@mr-cal mr-cal force-pushed the work/CRAFT-3070/platforms branch 2 times, most recently from 6de654d to ba471ac Compare August 21, 2024 23:57
@mr-cal mr-cal marked this pull request as ready for review August 21, 2024 23:57
@mr-cal mr-cal requested review from lengau, mattculler and tigarmo and removed request for mattculler August 22, 2024 15:11
snapcraft/commands/remote.py Show resolved Hide resolved
Copy link
Contributor

@tigarmo tigarmo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice!

docs/explanation/remote-build.rst Show resolved Hide resolved
docs/explanation/remote-build.rst Outdated Show resolved Hide resolved
snapcraft/commands/remote.py Show resolved Hide resolved
Signed-off-by: Callahan Kovacs <callahan.kovacs@canonical.com>
@mr-cal mr-cal merged commit 7ea9136 into main Aug 23, 2024
8 of 10 checks passed
@mr-cal mr-cal deleted the work/CRAFT-3070/platforms branch August 23, 2024 21:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
3 participants