Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(registries): add list-registries command #5014

Merged
merged 2 commits into from
Sep 9, 2024
Merged

feat(registries): add list-registries command #5014

merged 2 commits into from
Sep 9, 2024

Conversation

mr-cal
Copy link
Collaborator

@mr-cal mr-cal commented Sep 5, 2024 •
edited
Loading

  • Have you followed the guidelines for contributing?
  • Have you signed the CLA?
  • Have you successfully run tox run -m lint?
  • Have you successfully run tox run -e test-py310? (supported versions: py39, py310, py311, py312)

Add support for the list-registries command.

Fixes #5001
(CRAFT-3295)

@mr-cal mr-cal force-pushed the work/CRAFT-3295/list-registry-sets branch 2 times, most recently from ac0de40 to 849f293 Compare September 5, 2024 16:25
@mr-cal mr-cal force-pushed the work/CRAFT-3295/list-registry-sets branch from 849f293 to f142e86 Compare September 5, 2024 17:32
lengau
lengau approved these changes Sep 5, 2024
View reviewed changes
Copy link
Contributor

@lengau lengau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mr-cal mr-cal force-pushed the work/CRAFT-3295/list-registry-sets branch from f142e86 to d43477e Compare September 6, 2024 14:52
sergiusens
sergiusens reviewed Sep 6, 2024
View reviewed changes
snapcraft/cli.py Outdated Show resolved Hide resolved
@mr-cal mr-cal removed the request for review from cmatsuoka September 6, 2024 17:06
@mr-cal mr-cal force-pushed the work/CRAFT-3295/list-registry-sets branch from 9c1cd93 to 4c90cc9 Compare September 6, 2024 20:10
@mr-cal mr-cal added the squash label Sep 6, 2024
@mr-cal @sergiusens
feat(registries): add list-registries command
f719043 
Signed-off-by: Callahan Kovacs <callahan.kovacs@canonical.com>
@mr-cal @sergiusens
chore: feedback from PR
cb08e22 
Signed-off-by: Callahan Kovacs <callahan.kovacs@canonical.com>
@sergiusens sergiusens force-pushed the work/CRAFT-3295/list-registry-sets branch from 4c90cc9 to cb08e22 Compare September 9, 2024 16:09
@sergiusens sergiusens enabled auto-merge (squash) September 9, 2024 16:09
@sergiusens sergiusens merged commit 536541c into hotfix/8.4 Sep 9, 2024
8 of 10 checks passed
@sergiusens sergiusens deleted the work/CRAFT-3295/list-registry-sets branch September 9, 2024 17:30
@mr-cal mr-cal mentioned this pull request Sep 10, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lengau lengau lengau approved these changes

@sergiusens sergiusens sergiusens approved these changes

Assignees
No one assigned
Labels
squash
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mr-cal @sergiusens @lengau