Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[do-not-merge] chore: check craft-cli changes #5016

Closed

Conversation

dariuszd21
Copy link

@dariuszd21 dariuszd21 commented Sep 5, 2024

  • Have you followed the guidelines for contributing?
  • Have you signed the CLA?
  • Have you successfully run tox run -m lint?
  • Have you successfully run tox run -e test-py310? (supported versions: py39, py310, py311, py312)

This PR only checks if changes introduced in canonical/craft-cli#271 breaks something

Signed-off-by: Dariusz Duda <dariusz.duda@canonical.com>
@dariuszd21 dariuszd21 force-pushed the work/display_parameters_in_help branch from d59cc02 to 5c39f15 Compare September 5, 2024 21:46
Copy link

codecov bot commented Sep 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.57%. Comparing base (654871d) to head (5c39f15).
Report is 548 commits behind head on main.

❗ There is a different number of reports uploaded between BASE (654871d) and HEAD (5c39f15). Click for more details.

HEAD has 1 upload less than BASE
Flag BASE (654871d) HEAD (5c39f15)
2 1
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5016      +/-   ##
==========================================
- Coverage   94.88%   89.57%   -5.31%     
==========================================
  Files         658      335     -323     
  Lines       55189    22283   -32906     
==========================================
- Hits        52364    19960   -32404     
+ Misses       2825     2323     -502     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dariuszd21 dariuszd21 closed this Sep 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant