Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(models): add registries models #5049

Merged
merged 2 commits into from
Sep 20, 2024
Merged

feat(models): add registries models #5049

merged 2 commits into from
Sep 20, 2024
+161 −18

Conversation

mr-cal
Copy link
Collaborator

@mr-cal mr-cal commented Sep 18, 2024

  • Have you followed the guidelines for contributing?
  • Have you signed the CLA?
  • Have you successfully run tox run -m lint?
  • Have you successfully run tox run -e test-py310? (supported versions: py39, py310, py311, py312)

Adds pydantic models for registries.

Fixes #5019
(CRAFT-3332)

@mr-cal
feat(models): add registries models
c350b09 
Signed-off-by: Callahan Kovacs <callahan.kovacs@canonical.com>
@mr-cal mr-cal mentioned this pull request Sep 18, 2024
Merged
4 tasks
dariuszd21
dariuszd21 approved these changes Sep 20, 2024
View reviewed changes
Copy link

@dariuszd21 dariuszd21 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

snapcraft/models/assertions.py Outdated Show resolved Hide resolved
tests/unit/models/test_assertions.py Outdated Show resolved Hide resolved
tests/unit/models/test_assertions.py Outdated Show resolved Hide resolved
tests/unit/models/test_assertions.py Outdated Show resolved Hide resolved
tests/unit/models/test_assertions.py Outdated Show resolved Hide resolved
@mr-cal mr-cal added the squash label Sep 20, 2024
@mr-cal
chore: feedback from PR
e4ce078 
Signed-off-by: Callahan Kovacs <callahan.kovacs@canonical.com>
@mr-cal mr-cal merged commit ad3483f into main Sep 20, 2024
8 of 10 checks passed
@mr-cal mr-cal deleted the work/CRAFT-3332/registries-model branch September 20, 2024 19:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lengau lengau lengau approved these changes

@dariuszd21 dariuszd21 dariuszd21 approved these changes

Assignees
No one assigned
Labels
squash
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

registries: create pydantic models
3 participants
@mr-cal @lengau @dariuszd21