Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: catch remote build errors #5052

Merged
merged 3 commits into from
Sep 20, 2024
Merged

fix: catch remote build errors #5052

merged 3 commits into from
Sep 20, 2024

Conversation

mr-cal
Copy link
Collaborator

@mr-cal mr-cal commented Sep 20, 2024 •
edited
Loading

  • Have you followed the guidelines for contributing?
  • Have you signed the CLA?
  • Have you successfully run tox run -m lint?
  • Have you successfully run tox run -e test-py310? (supported versions: py39, py310, py311, py312)
  • bump craft-application to 4.2.4
  • Adds documentation links to RemoteBuild and ESM errors
  • Catches RemoteBuild errors rather than raising them as internal errors

craft-application

4.2.4 (2024-Sep-20)

Remote build

  • Remote build errors are now a subclass of CraftError.

Fixes #4908
(CRAFT-3101)

lengau
lengau reviewed Sep 20, 2024
View reviewed changes
setup.py Outdated Show resolved Hide resolved
lengau
lengau approved these changes Sep 20, 2024
View reviewed changes
Copy link
Contributor

@lengau lengau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving conditional on fixing that typo :-)

snapcraft/application.py Show resolved Hide resolved
@mr-cal mr-cal force-pushed the work/CRAFT-3101/remote-build-errors branch from 0da8eea to 68d0556 Compare September 20, 2024 16:50
@mr-cal mr-cal force-pushed the work/CRAFT-3101/remote-build-errors branch from 68d0556 to 9caf772 Compare September 20, 2024 16:53
@mr-cal
build(deps): bump craft-application to 4.2.4
08a6cf4 
Signed-off-by: Callahan Kovacs <callahan.kovacs@canonical.com>
@mr-cal
fix: catch remote build errors
92f871f 
Signed-off-by: Callahan Kovacs <callahan.kovacs@canonical.com>
@mr-cal
fix: add documentation links to remote build and esm base errors
0577934 
Signed-off-by: Callahan Kovacs <callahan.kovacs@canonical.com>
@mr-cal mr-cal force-pushed the work/CRAFT-3101/remote-build-errors branch from 9caf772 to 0577934 Compare September 20, 2024 17:59
@mr-cal mr-cal added the rebase label Sep 20, 2024
@mr-cal mr-cal merged commit 711ac75 into hotfix/8.4 Sep 20, 2024
9 of 10 checks passed
@mr-cal mr-cal deleted the work/CRAFT-3101/remote-build-errors branch September 20, 2024 19:24
@mr-cal mr-cal mentioned this pull request Sep 20, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattculler mattculler mattculler approved these changes

@lengau lengau lengau approved these changes

Assignees
No one assigned
Labels
rebase
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mr-cal @lengau @mattculler