Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: migrate to starflow #5225

Open
wants to merge 344 commits into
base: main
Choose a base branch
from
Open

refactor: migrate to starflow #5225

wants to merge 344 commits into from
+5,926 −5,043

Conversation

bepri
Copy link
Contributor

@bepri bepri commented Jan 29, 2025 •
edited
Loading

  • Have you followed the guidelines for contributing?
  • Have you signed the CLA?
  • Have you successfully run tox run -m lint?
  • Have you successfully run tox run -e test-py310? (supported versions: py39, py310, py311, py312)

Should be reviewable on a commit-by-commit basis. Comments will be left on individual files explaining why some changes were necessary. As some words of encouragement: about 250 of the file changes were purely from make format!

mr-cal and others added 30 commits June 9, 2023 15:38
@mr-cal
lint: ignore ruff SIM117 (#90)
f3c4f88 
Signed-off-by: Callahan Kovacs <callahankovacs@gmail.com>
@renovate
chore(deps): update dependency tox-gh to v1.2.0 (#92)
afc4246 
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
@renovate
chore(deps): update dependency lint/ruff to v0.0.272 (#91)
f40aae9 
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
@mr-cal
meta: update versioning scheme (#86)
0b9e9cf 
Signed-off-by: Callahan Kovacs <callahankovacs@gmail.com>
@tigarmo
lint: fix mypy config to 'recurse' (#94)
296c5dd 
`module = ["starcraft"]` only checks checks the `starcraft` main
package, and not any sub-packages and modules.
@renovate
chore(deps): update development dependencies (non-major) (#95)
72c7781 
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
@mr-cal
meta: add dirty flag to versioning scheme (#96)
8c64fc4
@mr-cal
ci: lint docs in all directories (#98)
0f6657d 
Files like README.md and HACKING.md are linted by sphinx-lint.

Signed-off-by: Callahan Kovacs <callahankovacs@gmail.com>
@tigarmo
tools: fix 'setuptools.package.find' directive (#97)
9985d46 
The directive is finnicky with regards to globbing, so the tests and
docs were being included in the final wheel package.
@tigarmo
tests: provide a fixture with the project's 'main' module (#99)
25d1c10 
The idea is this: since we have a few tests that are worth running in
"downstream" projects (those that merge starbase periodically), instead
of having to adapt every test individually in every downstream project
we'll use a fixture (project_main_module) that provides the imported
module object. So in starbase is returns the 'starcraft' module.

The tests are then updated to use this fixture instead of importing the
module directly. Downstream projects therefore only need to update the
fixture's implementation and the tests will (well, should) work.
@lengau
coverage: automatically exclude type checking blocks (#100)
61afd7e
@lengau
ruff: remove type-checking guard blocks (#101)
ab5e737
@lengau
tox: pass CI environment variable (#102)
3f7c6fa
@lengau @tigarmo
tools: Add release GH action (#103)
6363b31 
Co-authored-by: Tiago Nobrega <tiago.nobrega@canonical.com>
@lengau
pyproject: only include the actual package in wheel file (#108)
3769823 
Fixes #84
@lengau
tox: improve UX (#106)
8b8fed8
@lengau
ci: separate unit and integration tests (#107)
3244cc2
@lengau
ci: make release publisher workflow fetch correct tags (#110)
41f0124
@lengau
renovate: fix scheduling (#113)
c634986
@renovate
chore(deps): update development dependencies (non-major) (#115)
6a8bb7f 
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
@renovate
chore(deps): update release-drafter/release-drafter action to v5.24.0 (…
5faae73 
…#117)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
@renovate
chore(deps): update dependency lint/ruff to v0.0.284 (#119)
be3ae62 
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
@renovate
chore(deps): update dependency tox-gh to v1.3.1 (#121)
366e466 
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
@renovate
chore(deps): update documentation dependencies (#120)
2a28541 
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
@renovate @sergiusens
chore(deps): update dependency docs/sphinx to v7
3fca437
@lengau @sergiusens
Update pyproject.toml
841c322
@renovate
chore(deps): update dependency docs/furo to v2023.8.19 (#122)
9d017f3 
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
@renovate
chore(deps): update dependency lint/ruff to v0.0.285 (#123)
25c3c1d 
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
@renovate
chore(deps): update development dependencies (non-major) (#124)
a913629 
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
@sergiusens
docs: add conventional commits as part of the style
8322768 
Signed-off-by: Sergio Schvezov <sergio.schvezov@canonical.com>
bepri added 23 commits February 11, 2025 13:38
@bepri
build: remove all requirements files and generate requirements with uv
081a66d
@bepri
chore: migrate last of setup.py
6c02152
@bepri
chore: remove unused tools
237e84d
@bepri
build: delete tox.ini
18a7596
@bepri
chore: organize gitignore
f2be4e2 
This commit doesn't remove any entries, it only organizes them into nice categories
@bepri
style: bring in starbase formatter rules
945ab15
@bepri
test: mark slow tests
b2703f0
@bepri
chore: remove outdated/unused top-level files
eef0002
@bepri
docs: delete now-obsolete TESTING.md
eeb8424 
The only part of TESTING.md that remained relevant to modern Snapcraft was the information on Spread, which itself was slightly out of date. This migrates that Spread info to HACKING.MD and deletes the rest.
@bepri
docs: update HACKING.md with new environment information
591c198
@bepri
build: add python-apt wheels
3d2480c
@bepri
ci: update workflow files for starflow/uv
a347b7c
@bepri
style: add pre-commit config
82d8f2e
@bepri
ci(docs): update readthedocs config to use uv
0dedd09
@bepri
chore: correct all typing errors
50c2c41
@bepri
style: run prettier
3aa02f5
@bepri
ci: configure starflow test run
022cdad
@bepri
chore: move docutils into docs dependency group
d4078a0
@bepri
chore: pin craft-application for test failures
b98588d
@bepri
fix(docs): properly ignore lines being too long for now
00223d8
@bepri
test(spread): remove nonexistent files from spread.yaml
963ad50
@bepri
ci: make trivy ignore things we don't need to scan
0dd7694 
requirements-noble.txt cannot be built by Trivy and there's
no reason for us to scan spread tests
@bepri
fix: adjust crystal plugin for new data_files location
54b12c1
@bepri bepri force-pushed the work/starflow-migration branch from 2a2b5aa to 54b12c1 Compare February 11, 2025 18:43
mr-cal added a commit that referenced this pull request Feb 11, 2025
@mr-cal
fix(extensions): resources path for QtWebEngineProcess on kde-neon-6 (#…
9d05037 
…5250)

This line was added in #4823 in
d801346

However, the `export` was missing in the original commit. This error was
picked up by shellcheck in #5225. I'm moving it into a separate PR for
trackability.

Signed-off-by: Callahan Kovacs <callahan.kovacs@canonical.com>
@bepri bepri force-pushed the work/starflow-migration branch from 60f38ab to 91a85eb Compare February 11, 2025 19:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lengau lengau lengau approved these changes

@medubelko medubelko medubelko approved these changes

@mr-cal mr-cal mr-cal approved these changes

Assignees

@bepri bepri

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
10 participants
@bepri @mr-cal @lengau @medubelko @tigarmo @sergiusens @syu-w @mattculler @dariuszd21 @upils