Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update plugin build error message #5249

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

cmatsuoka
Copy link
Contributor

Update craft-parts to obtain the combined output in case of plugin
build error. This results in better information on the causes of
the failure.

Signed-off-by: Claudio Matsuoka claudio.matsuoka@canonical.com

  • Have you followed the guidelines for contributing?
  • Have you signed the CLA?
  • Have you successfully run tox run -m lint?
  • Have you successfully run tox run -e test-py310? (supported versions: py39, py310, py311, py312)

Update craft-parts to obtain the combined output in case of plugin
build error. This results in better information on the causes of
the failure.

Signed-off-by: Claudio Matsuoka <claudio.matsuoka@canonical.com>
Copy link

codecov bot commented Feb 11, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.71%. Comparing base (654871d) to head (e6689e0).
Report is 697 commits behind head on main.

❗ There is a different number of reports uploaded between BASE (654871d) and HEAD (e6689e0). Click for more details.

HEAD has 1 upload less than BASE
Flag BASE (654871d) HEAD (e6689e0)
2 1
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5249      +/-   ##
==========================================
- Coverage   94.88%   89.71%   -5.17%     
==========================================
  Files         658      343     -315     
  Lines       55189    22687   -32502     
==========================================
- Hits        52364    20354   -32010     
+ Misses       2825     2333     -492     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant