Skip to content

feat: add pc-gadget init template #5449

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

feat: add pc-gadget init template #5449

wants to merge 2 commits into from

Conversation

mr-cal
Copy link
Collaborator

@mr-cal mr-cal commented Apr 29, 2025

  • Have you followed the guidelines for contributing?
  • Have you signed the CLA?
  • Have you successfully run make lint?
  • Have you successfully run make test?

This PR prototypes using a git submodule for the pc-gadget init profile.

If this approach works and the pc-gadget repo gets tagged releases, snapcraft can automatically update the submodule via renovate.

This can be tested for the next 30 days on the latest/edge/pr-5449 branch.

@mr-cal mr-cal changed the title feat: add pc-gadget template as a submodule feat: add pc-gadget init template Apr 29, 2025
@mr-cal mr-cal force-pushed the work/gadget-template branch from ff1069a to 68d1e59 Compare April 29, 2025 16:05
@farshidtz
Copy link
Member

Thanks @mr-cal for prototyping this.

This works as expected, but keep in mind that there are several variants of the reference gadget snaps (pc and pi). With the submodules approach, this means one submodule for each variant.

For the pc gadget, there are a few maintained releases: https://github.com/canonical/pc-gadget/branches/all
For example, I'd image the following profile names:

  • pc-gadget-20 (maybe)
  • pc-gadget-22 (maybe)
  • pc-gadget-24
  • pc-gadget-26 (upcoming)

I think we can skip the classic gadgets.

For pi, we have to check the long term plans. If it is there to stay and not merged with pc, then:

  • pi-gadget-24

Skipping the older ones which were not multi-arch snaps.

Signed-off-by: Callahan Kovacs <callahan.kovacs@canonical.com>
@mr-cal mr-cal force-pushed the work/gadget-template branch from 68d1e59 to 21493d7 Compare May 9, 2025 18:24
@mr-cal
Copy link
Collaborator Author

mr-cal commented May 21, 2025

This was discussed in person, see meeting notes here.

The conclusion was that there isn't an agreement on what the init template or extension should look like. For this reason, I'm closing this prototype until there is consensus on the path forward.

@mr-cal mr-cal closed this May 21, 2025
@mr-cal mr-cal deleted the work/gadget-template branch May 21, 2025 12:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants