Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: Rich vertical list pattern #5306

Merged
merged 5 commits into from
Oct 24, 2024
Merged

Feat: Rich vertical list pattern #5306

merged 5 commits into from
Oct 24, 2024

Conversation

jmuzina
Copy link
Member

@jmuzina jmuzina commented Aug 16, 2024

Done

Builds macro, examples, and documentation for the rich vertical list pattern per design and spec

Fixes WD-14038

QA

Check if PR is ready for release

If this PR contains Vanilla SCSS code changes, it should contain the following changes to make sure it's ready for the release:

  • PR should have one of the following labels to automatically categorise it in release notes:
    • Feature 🎁, Breaking Change 💣, Bug 🐛, Documentation 📝, Maintenance 🔨.
  • Vanilla version in package.json should be updated relative to the most recent release, following semver convention:
    • if CSS class names are not changed it can be bugfix release (x.x.X)
    • if CSS class names are changed/added/removed it should be minor version (x.X.0)
    • see the wiki for more details
  • Any changes to component class names (new patterns, variants, removed or added features) should be listed on the what's new page.

Screenshots

Screenshot from 2024-08-16 14-57-46
Screenshot from 2024-08-16 14-57-53
Screenshot from 2024-08-16 14-58-03

@jmuzina jmuzina added Feature 🎁 New feature or request Don't merge labels Aug 16, 2024
@webteam-app
Copy link

@jmuzina jmuzina changed the title wip: Feat: Initial rich vertical list wip: Feat: Rich vertical list pattern Aug 16, 2024
@jmuzina jmuzina changed the title wip: Feat: Rich vertical list pattern Feat: Rich vertical list pattern Aug 16, 2024
@jmuzina jmuzina marked this pull request as ready for review August 16, 2024 19:07
Copy link
Contributor

@pastelcyborg pastelcyborg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like the combined demo link doesn't work

templates/_macros/rich-vertical-list.jinja Outdated Show resolved Hide resolved
templates/_macros/rich-vertical-list.jinja Outdated Show resolved Hide resolved
templates/_macros/rich-vertical-list.jinja Outdated Show resolved Hide resolved
@jmuzina
Copy link
Member Author

jmuzina commented Aug 16, 2024

Looks like the combined demo link doesn't work

Fixed, it was just pointing to the wrong url :)

@lyubomir-popov
Copy link
Contributor

looks great overall! 1 small glitch I noticed: some blurry logos - can you please use the official ones uploaded here https://assets.ubuntu.com/manager?tag=variable-width-logos-july-2024

docs suggestions:

  • flipped: mention that this is useful when having multiple vertical rich lists in a sequence, alternating between flipped and default#

  • this feels too empty. Can we say we should have at least one of the optional elements, e.g. a paragraph or list?

image

@jmuzina
Copy link
Member Author

jmuzina commented Aug 20, 2024

1 small glitch I noticed: some blurry logos - can you please use the official ones uploaded here https://assets.ubuntu.com/manager?tag=variable-width-logos-july-2024

The only Intel logo I found here doesn't look quite right - it has a dotted border and is too wide. Do you have a better one?
Screenshot 2024-08-20 at 4 03 50 PM

Also, the mockup uses Intel logo twice in the same logo section - it doesn't really matter for the example's sake, but I figured I'd mention it in case there is another logo we could use

Your other comments have been addressed!

@jmuzina jmuzina force-pushed the hoc-rich-vertical-list branch from 4401179 to f12c469 Compare August 20, 2024 20:16
@jmuzina jmuzina requested review from pastelcyborg and advl August 21, 2024 13:01
@jmuzina jmuzina force-pushed the hoc-rich-vertical-list branch from f12c469 to 00befe2 Compare August 21, 2024 17:12
@lyubomir-popov
Copy link
Contributor

demo not working

@jmuzina
Copy link
Member Author

jmuzina commented Aug 22, 2024

demo not working

@lyubomir-popov I've requested the demo to restart in Jenkins, it should be up in a few minutes if things are working properly

update: demo is now up

@jmuzina
Copy link
Member Author

jmuzina commented Aug 22, 2024

Tomorrow I'll update the images on this to use the new responsive image container. They get quite tall on smaller screens, so we can take advantage of a wider aspect ratio in those cases to make things look better.

@jmuzina jmuzina force-pushed the hoc-rich-vertical-list branch from 00befe2 to 4401179 Compare August 26, 2024 13:34
@jmuzina jmuzina force-pushed the hoc-rich-vertical-list branch from 6b17330 to cdf54f7 Compare August 26, 2024 15:16
@jmuzina jmuzina force-pushed the hoc-rich-vertical-list branch 3 times, most recently from 859b960 to a01e567 Compare September 10, 2024 20:13
@jmuzina jmuzina force-pushed the hoc-rich-vertical-list branch 2 times, most recently from faa703f to 070c4e5 Compare October 16, 2024 21:43
@bartaz
Copy link
Member

bartaz commented Oct 21, 2024

@jmuzina Please update/refresh the branch and let's discuss what are next steps or decisions to make.

@jmuzina jmuzina force-pushed the hoc-rich-vertical-list branch from 61f05af to f5218cf Compare October 23, 2024 15:25
@jmuzina jmuzina added Priority: High Should be addressed within current iteration and removed Blocked ⛔ Priority: Medium labels Oct 23, 2024
@jmuzina
Copy link
Member Author

jmuzina commented Oct 23, 2024

@lyubomir-popov @dgtlntv @mattea-turic Tall images that are stacked vertically on small and medium breakpoints can disrupt the page flow a bit by making the user scroll past a very tall image. This is especially noticeable in the flipped variant.

To account for this, the examples now have two images - one with a wide aspect ratio for smaller screens, and one with a taller aspect ratio for larger screens.

Ex: before:
Screenshot 2024-10-23 at 11 37 37 AM

After:
Screenshot 2024-10-23 at 11 38 16 AM

Let me know if you think this is unnecessary or if there's a better way around it - just wanted to make sure these look as presentable as possible for release :)

@jmuzina jmuzina marked this pull request as ready for review October 23, 2024 15:39
Copy link
Member

@bartaz bartaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@mattea-turic
Copy link

Quote reply

This looks good to me :)

@jmuzina jmuzina merged commit 432b600 into main Oct 24, 2024
14 checks passed
@jmuzina jmuzina deleted the hoc-rich-vertical-list branch October 24, 2024 14:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants