-
Notifications
You must be signed in to change notification settings - Fork 172
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat: Rich vertical list pattern #5306
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like the combined demo link doesn't work
templates/docs/examples/patterns/rich-list/vertical/default.html
Outdated
Show resolved
Hide resolved
Fixed, it was just pointing to the wrong url :) |
looks great overall! 1 small glitch I noticed: some blurry logos - can you please use the official ones uploaded here https://assets.ubuntu.com/manager?tag=variable-width-logos-july-2024 docs suggestions:
|
The only Intel logo I found here doesn't look quite right - it has a dotted border and is too wide. Do you have a better one? Also, the mockup uses Intel logo twice in the same logo section - it doesn't really matter for the example's sake, but I figured I'd mention it in case there is another logo we could use Your other comments have been addressed! |
4401179
to
f12c469
Compare
f12c469
to
00befe2
Compare
demo not working |
@lyubomir-popov I've requested the demo to restart in Jenkins, it should be up in a few minutes if things are working properly update: demo is now up |
Tomorrow I'll update the images on this to use the new responsive image container. They get quite tall on smaller screens, so we can take advantage of a wider aspect ratio in those cases to make things look better. |
00befe2
to
4401179
Compare
6b17330
to
cdf54f7
Compare
859b960
to
a01e567
Compare
faa703f
to
070c4e5
Compare
@jmuzina Please update/refresh the branch and let's discuss what are next steps or decisions to make. |
61f05af
to
f5218cf
Compare
…ja macro code snippets
@lyubomir-popov @dgtlntv @mattea-turic Tall images that are stacked vertically on small and medium breakpoints can disrupt the page flow a bit by making the user scroll past a very tall image. This is especially noticeable in the flipped variant. To account for this, the examples now have two images - one with a wide aspect ratio for smaller screens, and one with a taller aspect ratio for larger screens. Let me know if you think this is unnecessary or if there's a better way around it - just wanted to make sure these look as presentable as possible for release :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thanks!
This looks good to me :) |
Done
Builds macro, examples, and documentation for the rich vertical list pattern per design and spec
Fixes WD-14038
QA
Check if PR is ready for release
If this PR contains Vanilla SCSS code changes, it should contain the following changes to make sure it's ready for the release:
Feature 🎁
,Breaking Change 💣
,Bug 🐛
,Documentation 📝
,Maintenance 🔨
.package.json
should be updated relative to the most recent release, following semver convention:Screenshots