-
Notifications
You must be signed in to change notification settings - Fork 172
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix icon margin within small buttons #5387
Conversation
mcslayer is not a collaborator of the repo |
# Conflicts: # package.json
@bartaz Hi! I’ve finished working on the code, fixed the issues, and reviewed everything we discussed. The code is now ready for further review or implementation. I’d appreciate it if you could take a look so we can move forward. |
Co-authored-by: Bartek Szopka <83575+bartaz@users.noreply.github.com>
LGTM Design +1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @mcslayer for the fix and responsiveness. That's really helpful.
Done
Based on my understanding, the logic is as follows:
When no icon exists, the space is applied symmetrically to both the left and right sides:
[x<span>x]
.When an icon is added, the space is adjusted accordingly: either
[x/2<icon>x/2<span>x]
or[x<span>x/2<icon>x/2]
.I have fixed this and included additional examples for the button/icon section for clarity.
#5386
QA
examples/patterns/buttons/icon
, which includes various button sizes with iconsCheck if PR is ready for release
If this PR contains Vanilla SCSS code changes, it should contain the following changes to make sure it's ready for the release:
Feature 🎁
,Breaking Change 💣
,Bug 🐛
,Documentation 📝
,Maintenance 🔨
.package.json
should be updated relative to the most recent release, following semver convention: