fix(tabs): Bottom border of .p-tabs__list
spans full width on all screen sizes
#5457
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Done
Adjusts the border of the
p-tabs__list
so that it spans full width on all screen sizes.Previously, a pseudoelement
.p-tabs__list::after
was used as a pseudo-border, but this pseudo-border spanned the width of.p-tabs__list
, which is a horizontally scrolling flex container. So, the border spans the constrained width of the container, not the width of the list itself.This alters the border to use an inset box shadow, basing the border sizing off of the box model of
p-tabs__list
instead. This correctly forces the bottom border to span the full width of the tabs list on all screen sizes.Fixes #5446
Fixes WD-18333
QA
Check if PR is ready for release
If this PR contains Vanilla SCSS or macro code changes, it should contain the following changes to make sure it's ready for the release:
Feature 🎁
,Breaking Change 💣
,Bug 🐛
,Documentation 📝
,Maintenance 🔨
.package.json
should be updated relative to the most recent release, following semver conventionScreenshots
Tabbed content
Before
After
Docs
Before
After