Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Create modifier class to 'no-full-stop' be applied to 'p-stepped-list' and it's variants #5465

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

petesfrench
Copy link
Contributor

@petesfrench petesfrench commented Feb 4, 2025

Done

  • Create modifier class to 'no-full-stop' be applied to 'p-stepped-list' and it's variants. This removes the full stop and aligns the counter to the left

Fixes https://github.com/canonical/ubuntu.com/pull/14702/files/214ab12ae0503642d147ea6e9f1cfda172c84352#r1940227885

QA

  • Open demo
  • [Add QA steps]
  • Review updated documentation:
    • [List any updated documentation for review]

Check if PR is ready for release

If this PR contains Vanilla SCSS or macro code changes, it should contain the following changes to make sure it's ready for the release:

  • PR should have one of the following labels to automatically categorise it in release notes:
    • Feature 🎁, Breaking Change 💣, Bug 🐛, Documentation 📝, Maintenance 🔨.
  • Vanilla version in package.json should be updated relative to the most recent release, following semver convention
    • if existing APIs (CSS classes & macro APIs) are not changed it can be a bugfix release (x.x.X)
    • if existing APIs (CSS classes & macro APIs) are changed/added/removed it should be a minor version (x.X.0)
    • see the wiki for more details
  • Any changes to component class names (new patterns, variants, removed or added features) or macros should be listed on the what's new page.

Screenshots

[if relevant, include a screenshot or screen capture]

@webteam-app
Copy link

@petesfrench
Copy link
Contributor Author

Hey Vanilla folk, I had to apply this to one of my PRs, so I made a quick PR to demo it. LMK if it is something we would like in Vanilla and I can continue work on it.

@jmuzina
Copy link
Member

jmuzina commented Feb 4, 2025

@lyubomir-popov what do you think of the example?

Default variant:
image

no-full-stop variant:
image

More than 9 items:
image

@lyubomir-popov
Copy link
Contributor

This is a rather opinionated change that hasn't gone through the contribution process on the design side. Can we please ensure we have a discussion via the official contribution process, before we review this pr.

A few open questions:

  • Left alinging works well when lists are less than 9 items long. Once we have double digit counters, number alignment rules come into place. Hence the current right alignment. Do we want to support different alignments based on item count?
  • A dot is needed when a list has nested list items. If we support variants with and without dots, we'd have to clearly disambiguate when to use which, and what happens if both need to be placed in close proximity

@jmuzina jmuzina added the WG: Proposal Working group proposals label Feb 6, 2025
@jmuzina
Copy link
Member

jmuzina commented Feb 6, 2025

Added to DSWG agenda for Monday 10 February.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature 🎁 New feature or request WG: Proposal Working group proposals
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants