Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Misc] Improve code coverage #16

Merged
merged 3 commits into from
Jul 2, 2024
Merged

Conversation

anirudhprasad-sap
Copy link
Contributor

@anirudhprasad-sap anirudhprasad-sap commented Jun 27, 2024

image

Copy link

sonarqubecloud bot commented Jul 1, 2024

@anirudhprasad-sap anirudhprasad-sap changed the title [Feat] Auto propose shoot domain [Misc] Enhance code coverage Jul 1, 2024
@anirudhprasad-sap anirudhprasad-sap changed the title [Misc] Enhance code coverage [Misc] Improve code coverage Jul 1, 2024
@anirudhprasad-sap anirudhprasad-sap marked this pull request as ready for review July 1, 2024 11:14
Copy link
Contributor

@Pavan-SAP Pavan-SAP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.. minor suggestion for tests inline.

test/cap-op-plugin.test.js Show resolved Hide resolved
@anirudhprasad-sap anirudhprasad-sap merged commit e7a0fa1 into main Jul 2, 2024
8 checks passed
@anirudhprasad-sap anirudhprasad-sap deleted the proposeClusterDomain branch July 2, 2024 09:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants