Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SDMEXT-590] Display attachments specific to repository #86

Merged
merged 11 commits into from
Jan 24, 2025

Conversation

rishikunnath2747
Copy link
Contributor

This PR adds the check for repository ID, so that the user does not see attachments that were uploaded to a different repository, than the one with which the application is currently deployed. It also fixes the bug when using multiple repositories, if the application is deployed with a repository and an entity is created with a few attachments in them, a folder is created for that entity in the repository. When deployed with a different repository, it will find the folderId from the db and try to create attachments in it, but it will fail as the folder was created with a different repository. This is resolved by adding a repositoryId check while looking for folder. It also modifies the duplicate file check to check only in the current repository.

JIRA BL : SDMEXT-590

@@ -1,8 +1,8 @@
using { Attachments} from '@cap-js/attachments';
extend aspect Attachments with {
folderId : String @title: 'Folder ID' @readonly;
repositoryId : String @title: 'Repository ID' @readonly default null;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

make this as Hidden

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@yashmeet29 yashmeet29 merged commit 9a13b46 into develop Jan 24, 2025
7 checks passed
@yashmeet29 yashmeet29 deleted the SDMEXT-590/readAttachmentsSpecificToRepository branch January 24, 2025 05:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants