[SDMEXT-815]/attachmentCreationOnUpload#91
Merged
yashmeet29 merged 8 commits intodevelopfrom Feb 6, 2025
Merged
Conversation
yashmeet29
requested review from
maheshsooryambylu,
rashmiangadi11 and
rishikunnath2747
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
…b.com/cap-js/sdm into SDMEXT-815/attachmentCreationOnUpload
lib/handler/index.js
Outdated
| try { | ||
| return await axios.get(getAttachmentURL, config); | ||
| } catch (error) { | ||
| let statusText = "An Error Occurred"; |
Contributor
There was a problem hiding this comment.
Can we place this on constants
lib/sdm.js
Outdated
| ); | ||
| if (response.status == 201) { | ||
| d.folderId = parentId; | ||
| d.url = response.data.succinctProperties["cmis:objectId"]; |
Contributor
There was a problem hiding this comment.
response.data? check for undefined and null
rashmiangadi11
approved these changes
Feb 6, 2025
rishikunnath2747
approved these changes
Feb 6, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Jira: https://jira.tools.sap/browse/SDMEXT-815
This PR implements attachments creation on upload of attachments similar to Java plugin. Rename operation is triggered on save of the entity.
In this PR i am also adding a check for SDM roles for creation of attachments.
Scenarios Tested on Cloud: