update order col #1123
Merged
update order col #1123
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ksneab7
reviewed
Mar 25, 2024
| @@ -466,7 +467,7 @@ def _update_helper(self, df_series_clean: Series, profile: dict) -> None: | |||
| Update col profile properties with clean dataset and its known null parameters. | |||
|
|
|||
| :param df_series_clean: df series with nulls removed | |||
| :type df_series_clean: pandas.core.series.Series | |||
| :type df_series_clean: polars.series.series.Series | |||
There was a problem hiding this comment.
Suggested change
| :type df_series_clean: polars.series.series.Series | |
| :type df_series_clean: polars.Series |
There was a problem hiding this comment.
I put polars.series.series.Series since when you get the type of any polars series it returns <class 'polars.series.series.Series'>. However if you think I should change it to polars.Series still happy to do so.
| @@ -478,10 +479,13 @@ def update(self, df_series: Series) -> OrderColumn: | |||
| Update the column profile. | |||
|
|
|||
| :param df_series: df series | |||
| :type df_series: pandas.core.series.Series | |||
| :type df_series: polars.series.series.Series | |||
There was a problem hiding this comment.
Suggested change
| :type df_series: polars.series.series.Series | |
| :type df_series: polars.Series |
micdavis
previously approved these changes
Mar 25, 2024
auto-merge was automatically disabled
March 27, 2024 18:56
Head branch was pushed to by a user without write access
ksneab7
approved these changes
Mar 27, 2024
micdavis
approved these changes
Mar 29, 2024
abajpai15
pushed a commit
to abajpai15/DataProfiler
that referenced
this pull request
Apr 1, 2024
* update order col * fix pandas df in update * update types in comments
abajpai15
pushed a commit
to abajpai15/DataProfiler
that referenced
this pull request
Apr 11, 2024
* update order col * fix pandas df in update * update types in comments
abajpai15
pushed a commit
to abajpai15/DataProfiler
that referenced
this pull request
Apr 15, 2024
* update order col * fix pandas df in update * update types in comments
abajpai15
pushed a commit
to abajpai15/DataProfiler
that referenced
this pull request
Apr 15, 2024
* update order col * fix pandas df in update * update types in comments
atl1502
added a commit
that referenced
this pull request
Apr 16, 2024
* update order col * fix pandas df in update * update types in comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.