HPPA fix mem operands access and instruction printing#2746
Merged
Rot127 merged 6 commits intocapstone-engine:nextfrom Jul 6, 2025
Merged
HPPA fix mem operands access and instruction printing#2746Rot127 merged 6 commits intocapstone-engine:nextfrom
Rot127 merged 6 commits intocapstone-engine:nextfrom
Conversation
jiegec
approved these changes
Jun 30, 2025
Rot127
requested changes
Jun 30, 2025
Collaborator
Rot127
left a comment
There was a problem hiding this comment.
Changes look good!
But we miss a test for the access details.
Can you please add a hand full of those.
After this we are good to go.
jiegec
approved these changes
Jul 6, 2025
Rot127
approved these changes
Jul 6, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Your checklist for this pull request
Detailed description
Test plan
Closing issues
closes #2736
closes #2717