Skip to content

HPPA fix mem operands access and instruction printing#2746

Merged
Rot127 merged 6 commits intocapstone-engine:nextfrom
R33v0LT:hppa
Jul 6, 2025
Merged

HPPA fix mem operands access and instruction printing#2746
Rot127 merged 6 commits intocapstone-engine:nextfrom
R33v0LT:hppa

Conversation

@R33v0LT
Copy link
Copy Markdown
Contributor

@R33v0LT R33v0LT commented Jun 29, 2025

Your checklist for this pull request

  • I've documented or updated the documentation of every API function and struct this PR changes.
  • I've added tests that prove my fix is effective or that my feature works (if possible)

Detailed description

  • Remove base_access field from HPPA_MEM operand and replace it for op->access
  • Add spaces between operands for better readability

Test plan

Closing issues

closes #2736
closes #2717

@github-actions github-actions bot added Python Bindings HPPA Arch labels Jun 29, 2025
Copy link
Copy Markdown
Collaborator

@Rot127 Rot127 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good!

But we miss a test for the access details.

Can you please add a hand full of those.
After this we are good to go.

@R33v0LT R33v0LT requested a review from Rot127 July 6, 2025 10:25
@Rot127 Rot127 merged commit 52329bc into capstone-engine:next Jul 6, 2025
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

HPPA Arch Python Bindings

Projects

None yet

Development

Successfully merging this pull request may close these issues.

HPPA - put spaces in the instruction mnemonic HPPA disassembler does not initialize op->access in some cases

3 participants