fix(orders): status change AJAX feedback and destructive action confirmation (#98)#163
Open
b3lz3but wants to merge 1 commit intocaptainpragmatic:masterfrom
Open
fix(orders): status change AJAX feedback and destructive action confirmation (#98)#163b3lz3but wants to merge 1 commit intocaptainpragmatic:masterfrom
b3lz3but wants to merge 1 commit intocaptainpragmatic:masterfrom
Conversation
…rmation (captainpragmatic#98) - Show API error messages inline in the modal instead of generic alert() - Parse response JSON on both success and error HTTP statuses - Add type-to-confirm dialog for destructive transitions (cancelled, failed) - Disable submit button until confirmation word matches - Close modal and show toast on success, display error in modal on failure - Reset confirmation state when modal is closed Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> Signed-off-by: Ciprian Radulescu <craps2003@gmail.com>
Contributor
Author
ChangesError handling fix (Audit #5):
Destructive confirmation (Audit #16):
No Python changes — template-only fix (1 file, ~80 lines net). @mostlyvirtual requesting your review. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
alert(). The response JSON is parsed on both success and error HTTP statuses.Closes #98
Test plan
Generated with Claude Code