refactor(tickets): migrate platform ticket list to shared components (#152)#167
Open
b3lz3but wants to merge 2 commits intocaptainpragmatic:masterfrom
Open
refactor(tickets): migrate platform ticket list to shared components (#152)#167b3lz3but wants to merge 2 commits intocaptainpragmatic:masterfrom
b3lz3but wants to merge 2 commits intocaptainpragmatic:masterfrom
Conversation
…aptainpragmatic#152) Replace 275 lines of inline HTML in the platform ticket list with shared components (list_page_header, list_page_filters, list_page_skeleton), matching the portal's 27-line architecture. Add TICKET_STATUS_TABS with staff-appropriate labels, pass shared component context from views, standardize date format to d.m.Y, and remove redundant TK avatar circles from both platform and portal ticket tables. Closes captainpragmatic#152 Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> Signed-off-by: Ciprian Radulescu <craps2003@gmail.com>
Contributor
Author
|
@mostlyvirtual — requesting review. Clean refactor: 275→28 lines using existing shared components. No behavior changes beyond date format standardization and TK avatar removal. |
gettext_lazy returns _StrPromise, not str, causing mypy dict-item error. Remove annotation to match portal's untyped pattern. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> Signed-off-by: Ciprian Radulescu <craps2003@gmail.com>
Contributor
Author
|
CI update: Fixed the mypy The @mostlyvirtual — this is a clean refactor: 275→28 lines using existing shared components. Would appreciate your review. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Replaces 275 lines of inline HTML in the platform ticket list with shared components, matching the portal's 27-line architecture. Net -241 lines.
Closes #152
What changed
list.html: 275 → 28 lines usinglist_page_header.html,list_page_filters.html,list_page_skeleton.htmlviews.py: AddedTICKET_STATUS_TABSconstant with staff labels ("Waiting on Customer"), expandedticket_listcontext with shared component variables (list_stats,filter_tabs,filter_search_url, etc.)tickets_table.html: Date format standardized tod.m.Y, TK avatar circle removed (show ticket number directly)tickets_table.html: Same TK avatar removaltickets/partials/header_action.htmlfor "New Ticket" buttonBefore/After
list_page_header.htmlincludelist_page_filters.htmllist_page_skeleton.htmlincludej M Y(24 Mar 2026)d.m.Y(24.03.2026)Test plan
🤖 Generated with Claude Code