Update OAuth2 property names to camelCase #85
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit updates the OAuth2 property names to use camelCase instead of snake_case to maintain consistency with JavaScript naming conventions. The changes include updating the property names in the HTML, JSON locale files, and the JavaScript backend code. The affected properties are `grant_type`, `access_token_url`, `authorization_endpoint`, `redirect_uri`, `open_authentication`, `client_id`, `client_secret`, and `client_credentials_in_body`, which have been changed to `grantType`, `accessTokenUrl`, `authorizationEndpoint`, `redirectUri`, `openAuthentication`, `clientId`, `clientSecret`, and `clientCredentialsInBody`, respectively. Additionally, the commit includes updates to the corresponding labels and placeholders in the UI components.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update OAuth2 Property Names to camelCase
What is being fixed - and why?
Description of problem/issue:
The OAuth2 property names were previously using snake_case, which is inconsistent with JavaScript naming conventions that prefer camelCase. This inconsistency can cause confusion and make the codebase harder to maintain.
Statement of why it needs fixing:
To maintain code consistency and adhere to JavaScript best practices, it's important that property names follow the camelCase convention. This update will improve code readability and maintainability.
What has changed?
Summary of changes and how they resolve the issue:
This commit updates the OAuth2 property names to use camelCase instead of snake_case. The changes include:
Affected properties:
grant_type->grantTypeaccess_token_url->accessTokenUrlauthorization_endpoint->authorizationEndpointredirect_uri->redirectUriopen_authentication->openAuthenticationclient_id->clientIdclient_secret->clientSecretclient_credentials_in_body->clientCredentialsInBodyAdditional updates:
By making these changes, the codebase will now follow a consistent naming convention, improving overall readability and maintainability.