Feature/implicit flow support #87
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…pport - Update .eslintrc.yml to exclude console logs in test files. - Modify package.json to bump version to 6.0.0 and update dependencies. - Add new fields (access_type, response_type, prompt) to locales, HTML, and JS files. - Implement implicit flow in OAuth2 node, with corresponding HTML form adjustments. - Improve input handling and proxy configuration in OAuth2Node class. - Add tests for new fields and flows.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is being fixed - and why?
Description of problem / issue:
Issue #79 highlights a problem with using the OAuth2 node for Google API authentication. Users are receiving an HTTP 200 response with an HTML sign-in page payload instead of the expected OAuth2 token, indicating an issue with handling the redirect to the Google sign-in page properly.
Statement of why it needs fixing:
Link to issue:
What has changed?
Summary of changes and how they resolve the issue:
Enhancements:
access_type,response_type,prompt) to locales, HTML, and JS files, allowing more comprehensive OAuth2 configurations.These changes resolve the limitations and issues identified in Issue #79 by providing a more flexible and robust OAuth2 node. The enhancements allow for proper handling of the Google OAuth2 authentication flow, including the additional confirmation screen and necessary redirects. This update ensures that users can authenticate seamlessly with Google APIs, obtaining the expected OAuth2 tokens without unnecessary complications.