feat(SideNav): add SideNav component into UIShell package #389
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for carbon-labs-react ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for carbon-labs-web-components ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
emyarod
force-pushed
the
18485-feat/carbon-labs-ui-shell-react
branch
from
3fde96e to
5555518
Compare
alisonjoseph
changed the title
alisonjoseph
changed the title
alisonjoseph
approved these changes
Jan 30, 2025
alisonjoseph
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes carbon-design-system/carbon#18485
This PR creates the SideNavbar (working name) package in the Carbon Labs repo
Changelog
New
Testing / Reviewing
confirm the SideNavbar is functionally identical to the existing UI Shell SideNav