-
Notifications
You must be signed in to change notification settings - Fork 40
feat(SideNav): add header menu button functionality at desktop #398
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(SideNav): add header menu button functionality at desktop #398
Conversation
✅ Deploy Preview for carbon-labs-react ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for carbon-labs-web-components ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good to me!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!! Thanks @alisonjoseph!
3e3c000
Closes carbon-design-system/carbon#18492
Changelog
isCollapsible
prop toSideNav
SideNav
Testing / Reviewing
Test hamburger functionality in Default story th
@oliviaflory do we want the overlay, currently by default it does pop up but I can make it configurable if needed.