Skip to content

feat(SideNav): add header menu button functionality at desktop #398

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

alisonjoseph
Copy link
Member

@alisonjoseph alisonjoseph commented Jan 31, 2025

Closes carbon-design-system/carbon#18492

Changelog

  • update example code (what shows up in stackblitz once published)
  • update overview page in storybook
  • add default shell story with theme component and demo content
  • isolate sidenav story
  • add new isCollapsible prop to SideNav
  • copy over tests from @carbon/react for SideNav
  • Commented out 2 failing tests - will look at separately, shouldn't block this
  • add basic test for new prop

Testing / Reviewing

Test hamburger functionality in Default story th

@oliviaflory do we want the overlay, currently by default it does pop up but I can make it configurable if needed.

Copy link

netlify bot commented Jan 31, 2025

Deploy Preview for carbon-labs-react ready!

Name Link
🔨 Latest commit 13f9038
🔍 Latest deploy log https://app.netlify.com/sites/carbon-labs-react/deploys/679ce2e2b2bd3a00084b1014
😎 Deploy Preview https://deploy-preview-398--carbon-labs-react.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Jan 31, 2025

Deploy Preview for carbon-labs-web-components ready!

Name Link
🔨 Latest commit 13f9038
🔍 Latest deploy log https://app.netlify.com/sites/carbon-labs-web-components/deploys/679ce2e258676c0008ac6cde
😎 Deploy Preview https://deploy-preview-398--carbon-labs-web-components.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@alisonjoseph alisonjoseph marked this pull request as ready for review January 31, 2025 13:59
Copy link
Member

@emyarod emyarod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me!

Copy link
Contributor

@IgnacioBecerra IgnacioBecerra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!! Thanks @alisonjoseph!

@jeffchew jeffchew added this pull request to the merge queue Jan 31, 2025
@jeffchew jeffchew removed this pull request from the merge queue due to a manual request Jan 31, 2025
@jeffchew jeffchew added this pull request to the merge queue Jan 31, 2025
Merged via the queue into carbon-design-system:main with commit 3e3c000 Jan 31, 2025
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Platforms] Implement hamburger for header navigation panel in Carbon labs/React
4 participants