feat: add network query example to fetch posts and comments #87
Conversation
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
…stency also removed unnecessary console.log Resolves: no-ticket Signed-off-by: [Balint Lendvai] <lendvai.balint@gmail.com>
… environments in message API functions Resolves: no-ticket Signed-off-by: [Balint Lendvai] <lendvai.balint@gmail.com>
…lanation - Updated layout to improve readability and added a detailed explanation of the data fetching process. - fixed posts responsive behaviour in mobile size - Removed unnecessary styles from the dynamic message section paragraphs. Resolves: no-ticket Signed-off-by: [Balint Lendvai] <lendvai.balint@gmail.com>
- Handled review comments - Changed error handling to set comments state correctly on failure. - Enhanced layout by introducing Stack components for better spacing and readability. - Updated paragraph elements for post body and comments for consistency. Resolves: no-ticket Signed-off-by: [Balint Lendvai] <lendvai.balint@gmail.com>
bogy0
force-pushed
the
feat/network-query-examples
branch
from
2b321ae to
9be2fbc
Compare
bogy0
changed the title
lee-chase
left a comment
lee-chase
left a comment
There was a problem hiding this comment.
Looks good to me, made a couple of small changes to pass linter and remove layer level which was not needed.
| try { | ||
| const response = await fetch( | ||
| // TODO: replace with actual endpoint URL | ||
| `https://jsonplaceholder.typicode.com/posts/${id}`, |
There was a problem hiding this comment.
I don't think we should be relying on an external provider here.
There was a problem hiding this comment.
maybe we can just rename this postHandlers file to something that indicates more that this is just an EXAMPLE, thats why this provider, or we can deploy our own dummy API somewhere in IBM Cloud that gives back something like this, but maybe thats overkill....
| try { | ||
| // TODO: handle production and development environments | ||
| const response = await fetch( | ||
| `http://localhost:5173/api/comments?postId=${postId}`, |
There was a problem hiding this comment.
Is there any way to remove that hardcoding here?
There was a problem hiding this comment.
@rodet Environment variables, single source of truth config file or runtime detection?
There was a problem hiding this comment.
i like the idea to use a single source of truth config combined with nconf. This way the default value that stored in the config file can be overwritten by setting some env variables.
https://www.npmjs.com/package/nconf/
4 participants
To be able to demonstrate better external API usage introduced two new API service:
getPostgetCommentsgetMessagecreated a Posts section in the Welcome page with comments where we render these external data.
This is how that section looks like after this change:
