-
Notifications
You must be signed in to change notification settings - Fork 794
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
AI doc update - Select & Date picker #4060
AI doc update - Select & Date picker #4060
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When flipping between the images, the scale and positioning shift slightly. Not sure if that's worth fixing though. Otherwise looks great to me!
Thanks, @tay1orjones! So, if I understand correctly, the shift you're referring to is due to the default and fluid components in the images, or something else? 🤔 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No notes. Ship it!
Oh seeing, @tay1orjones comment now. We do try to align some parts of the default/fluid images so they don't bounce so much. Sometimes its aligning the bases line or sometime its the text or icons in the field. Look at the "keyboard" image under "interactions" on the select page. Its not a deal break but is a nice visual polish moment to look out for. |
Hi @tay1orjones, @aagonzales, I tried fixing the positioning shift, please have a look! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, but I just spotted one more place on the style tab where we should swap out "default" for "non-AI"
Co-authored-by: Anna Gonzales <agonz@us.ibm.com>
Co-authored-by: Anna Gonzales <agonz@us.ibm.com>
|
||
A date picker can toggle between the AI variant and the non-AI variant depending | ||
on the user’s interaction. If the user manually overrides the AI-suggested | ||
content then the input will change from the AI variant to the default variant. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @Kritvi-bhatia17 just noticed this default to non-AI variant change in the usage tab for Date picker and Select component, rest is all good! 🚀
"content then the input will change from the AI variant to the non-AI variant."
|
||
A select can toggle between the AI variant and the non-AI variant depending on | ||
the user’s interaction. If the user manually overrides the AI-suggested content | ||
then the input will change from the AI variant to the default variant. Once |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"content then the input will change from the AI variant to the non-AI variant."
Thanks @alina-jacob! I also just noticed it while updating the other component will fix this in the upcoming PR! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Select component: Input field suggestions
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hi @Kritvi-bhatia17, just one more observation, the input field in this image should show some 'AI selected option'
And the menu item will subsequently reflect that (for both default and fluid states)
Here's an example from the dropdown component:
Subsequently, while showing the revert image, just change the option item.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @alina-jacob
I noticed that was already updating that in another PR.
Closes #4011 & #4038
AI work:
Changelog (both components)
Added in the Usage tab
Added in the Style tab
Bug fixes:
Changelog (only Select)
Added in the Style tab