-
Notifications
You must be signed in to change notification settings - Fork 795
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Docs] AI overview guidelines #4113
[Docs] AI overview guidelines #4113
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Co-authored-by: Alison Joseph <alisonejoseph@Gmail.com>
@alisonjoseph Also do you know what I need to do to resolve the merge conflict? |
@aagonzales I'll push a fix, this file actually doesn't even need to be in github |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me Anna! 🚀
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi Anna, pretty amazing work! 🔥
I just have a few small doubts I wanted to clarify.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- I have a small question: Although I know it's just Lorem ipsum text, should we use actual data for the "AI text area" since it's AI generated? Or should we just make the AI text area's data be different from the non-AI text area? 🤔
- Also, should the label "AI Text area" be in sentence case as "AI text area," or is it fine the way it is?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This image shows the styling difference between core carbon and the AI presence. I don't think it necessarily needs to have different content between the two like we'd want with showing the "revert option." The other components in the image don't have real data either so if we were to do real data we would change it across all the components in this image. We'd lose the component name in the label if we did but that's the trade of of doing spec vs real content. Are we trying to help people to understand the structure of the component or how to use the component here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh, I see your point. If I understand correctly, since we're showing the structure of the component, it's fine to go ahead with the Lorem Ipsum text. Thank you!
Co-authored-by: thyhmdo <77697351+thyhmdo@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, Anna! Everything is finally coming together well! 🔥❤️
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks great!
Related #3997
Added a new page under the guidelines sections for "Carbon for AI."
Changelog
New
Note
Ready for review but do not merge
We are waiting to roll this out at a specific time later in the week to publish at the same time as the Design for AI site udpates. Do not automatically merge it.