Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Menu buttons guidance PR #4455

Merged
merged 6 commits into from
Feb 5, 2025

Conversation

alina-jacob
Copy link
Member

Closes: #4447

Important links: Figma file

Context

[Usage Tab]

  • Updated image for height section
  • Updated content around heights
  • Updated images for width section
  • Updated Menu button's cover image
  • Updated content around Menu buttons styles (primary, tertiary, ghost)
  • Updated Combo button's cover image

[Style Tab]

  • Updated image for Menu button types

Copy link

vercel bot commented Jan 31, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
carbondesignsystem ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 5, 2025 2:28pm

Copy link
Member

@kennylam kennylam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

src/pages/components/menu-buttons/usage.mdx Show resolved Hide resolved
| Small | 32 / 2 |
| Medium | 40 / 2.5 |
| Large | 48 / 3 |

Menu items come in four sizes: extra small, small, medium, and large. See more
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The paragraph information in this section seems a little repetitive and staggered. I think it could all be consolidated above the table instead of having different sections of body copy. You could try something like this:
Screenshot 2025-02-03 at 1 54 34 PM

@laurenmrice
Copy link
Member

Just a few more things and this should be good to go:

  • Did you mean for this to be two paragraphs or one? Either is fine, but it just looks like more of the "See more..." sentence could be on the line above it, if it was meant to be one paragraph.
  • Instead of italics to call out the sizes, use semi-bold.
Screenshot 2025-02-05 at 8 39 26 AM
  • There needs to be focus on the first item in the small size in this image.
Screenshot 2025-02-05 at 8 42 22 AM

Copy link
Member

@laurenmrice laurenmrice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! ✅

@kodiakhq kodiakhq bot merged commit b80aa01 into carbon-design-system:main Feb 5, 2025
6 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants