CIP-0137 | Message Submission V2 + fixes#1141
Draft
the-headless-ghost wants to merge 4 commits intocardano-foundation:masterfrom
Draft
CIP-0137 | Message Submission V2 + fixes#1141the-headless-ghost wants to merge 4 commits intocardano-foundation:masterfrom
the-headless-ghost wants to merge 4 commits intocardano-foundation:masterfrom
Conversation
rphair
added
Category: Network
5 tasks
jpraynaud
approved these changes
Feb 24, 2026
Contributor
jpraynaud
left a comment
jpraynaud
left a comment
There was a problem hiding this comment.
LGTM 👍
Thanks @the-headless-ghost!
| - and uses these ids to request a batch of messages (which it has not received yet) | ||
|
|
||
| The outbound side is responsible for initiating the mini-protocol with a peer node, but the inbound side (i.e. the other node) is the one who asks for information. | ||
| In version 1, the outbound side is responsible for initiating the mini-protocol with a peer node, but the inbound side (i.e. the other node) is the one who asks for information. |
Contributor
There was a problem hiding this comment.
Maybe it would be helpful to explain how this works in V2?
Author
|
@jpraynaud @coot Im unable to complete this pull request. Could someone please clone it and take over from here? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Introduced Message Submission V2 and fixed minor issues.