-
Notifications
You must be signed in to change notification settings - Fork 213
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Browse files
Browse the repository at this point in the history
This pull request adds a data type `ChainTip` to the `Cardano.Wallet.Read` hierarchy. This type `ChainTip` is used in the ChainSync protocol to advertise the tip of the server's chain. It combines the information of a `ChainPoint` with a `BlockNo`. This pull requests also adds * Conversions to/from types in `ouroboros-consensus` for the networking layer ### Comments * The `NetworkLayer` currently uses the `BlockHeader` type for advertising the tip of the chain. However, this is strictly speaking incorrect, as the `BlockHeader` also includes a reference to the previous block header, which `ChainTip` does not. In the legacy code, we currently invent a value out of thin air — the new type `ChainTip` is more correct. * Subsequent pull requests will change the `NetworkLayer` interface to use `Read.ChainPoint` and `Read.ChainTip`. ### Issue Number ADP-3350
- Loading branch information
Showing
3 changed files
with
97 additions
and
8 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters