[ADP-3093] Temporarily reenable macOS tests #4042
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Unisay
reviewed
Jul 17, 2023
Unisay
reviewed
Jul 17, 2023
| @@ -144,15 +144,15 @@ steps: | |||
| - './nix/regenerate.sh' | |||
| agents: | |||
| system: ${macos} | |||
| if: 0 == 1 # Disabled for now until a macos mini is available | |||
| # if: 0 == 1 # Disabled for now until a macos mini is available | |||
There was a problem hiding this comment.
Any reason to leave it commented out and not deleting?
There was a problem hiding this comment.
Yes. — It's temporary until will get dedicated macOS Agents.
There was a problem hiding this comment.
Do you mean that once we have those agents you'll un-comment the if: 0 == 1 back?
There was a problem hiding this comment.
Do you mean that once we have those agents you'll un-comment the if: 0 == 1 back?
No, the other way round — once we have those Agents, I will delete the line.
HeinrichApfelmus
force-pushed
the
HeinrichApfelmus/ADP-3093/macos
branch
from
00055eb
to
263cc9f
Compare
HeinrichApfelmus
force-pushed
the
HeinrichApfelmus/ADP-3093/macos
branch
11 times, most recently
from
dacea72
to
e8f604a
Compare
HeinrichApfelmus
force-pushed
the
HeinrichApfelmus/ADP-3093/macos
branch
from
e8f604a
to
9335c73
Compare
|
Closing in favor of #4258 . |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request temporarily re-enables our macOS tests.