Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ADP-3091] Add memory benchmarks to CI #4043

Merged
merged 7 commits into from
Jul 18, 2023

Conversation

paolino
Copy link
Collaborator

@paolino paolino commented Jul 17, 2023

  • Add scripting around the memory benchmark.
  • Parameterized node and wallet configuration in cluster with the executable path.
  • Add working directory field to wallet launcher.
  • Add memory benchmark to the nightly pipeline.

ADP-3091

@paolino paolino self-assigned this Jul 17, 2023
@paolino paolino force-pushed the paolino/ADP-3091/add-memory-benchmark-to-CI branch from 8541590 to b16fb3b Compare July 17, 2023 15:49
Comment on lines +447 to +448
packages.benchmarks.cardano-wallet-benchmarks //
packages.benchmarks.cardano-wallet // {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This makes a little sense from the outside, is it a temporary state of the things?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No idea, how should it be done ?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I mean the fact that we have benchmarks in two different namespaces:
packages.benchmarks.cardano-wallet-benchmarks
packages.benchmarks.cardano-wallet

The questions are:

  • Why to have wallet benchmarks twice?
  • What's the difference between benchmarks.cardano-wallet-benchmars and benchmarks.cardano-wallet ?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In general, the nix expression packages.benchmarks.cardano-package-name contains the benchmark components of the cabal package cardano-package-name. In this case, we have two cabal packages: cardano-wallet and cardano-wallet-benchmarks.

Why to have wallet benchmarks twice?
What's the difference between benchmarks.cardano-wallet-benchmarks and benchmarks.cardano-wallet?

I have put the benchmarks in cardano-wallet-benchmarks into a separate packages because they do not have a compile-time dependency on cardano-wallet, only a run-time dependency.

I'm not against putting them in the same cardano-wallet.cabal file, but I felt that putting the run-time benchmarks into a separate package would be better for enforcing the phase separation (compile/run).

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, now I see your logic. This is more like a naming issue. I wonder if we can have this distinction "compile/runtime" reflected in the nix derivation names?

scripts/bench-memory.sh Outdated Show resolved Hide resolved
@paolino paolino force-pushed the paolino/ADP-3091/add-memory-benchmark-to-CI branch from e4aeeee to 450cc87 Compare July 17, 2023 16:19
@paolino paolino requested a review from Unisay July 17, 2023 16:19
Base automatically changed from HeinrichApfelmus/ADP-3086/memory-benchmark to master July 17, 2023 20:04
Copy link
Contributor

@Unisay Unisay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Naming of benchmarks is slightly confusing without an explanation like the one that @HeinrichApfelmus has provided, but its a minor problem.

@paolino paolino added this pull request to the merge queue Jul 18, 2023
Merged via the queue into master with commit 63cda0e Jul 18, 2023
2 checks passed
@paolino paolino deleted the paolino/ADP-3091/add-memory-benchmark-to-CI branch July 18, 2023 08:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants