-
Notifications
You must be signed in to change notification settings - Fork 213
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ADP-3091] Add memory benchmarks to CI #4043
Conversation
8541590
to
b16fb3b
Compare
packages.benchmarks.cardano-wallet-benchmarks // | ||
packages.benchmarks.cardano-wallet // { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This makes a little sense from the outside, is it a temporary state of the things?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No idea, how should it be done ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I mean the fact that we have benchmarks in two different namespaces:
packages.benchmarks.cardano-wallet-benchmarks
packages.benchmarks.cardano-wallet
The questions are:
- Why to have wallet benchmarks twice?
- What's the difference between
benchmarks.cardano-wallet-benchmars
andbenchmarks.cardano-wallet
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In general, the nix expression packages.benchmarks.cardano-package-name
contains the benchmark components of the cabal package cardano-package-name
. In this case, we have two cabal packages: cardano-wallet
and cardano-wallet-benchmarks
.
Why to have wallet benchmarks twice?
What's the difference betweenbenchmarks.cardano-wallet-benchmarks
andbenchmarks.cardano-wallet
?
I have put the benchmarks in cardano-wallet-benchmarks
into a separate packages because they do not have a compile-time dependency on cardano-wallet
, only a run-time dependency.
I'm not against putting them in the same cardano-wallet.cabal
file, but I felt that putting the run-time benchmarks into a separate package would be better for enforcing the phase separation (compile/run).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, now I see your logic. This is more like a naming issue. I wonder if we can have this distinction "compile/runtime" reflected in the nix derivation names?
e4aeeee
to
450cc87
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Naming of benchmarks is slightly confusing without an explanation like the one that @HeinrichApfelmus has provided, but its a minor problem.
ADP-3091