Move Redeemer type to Write.Tx.Redeemers module
#4047
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Anviking
force-pushed
the
anviking/ADP-3081/move-Redeemer-type
branch
2 times, most recently
from
c298a89
to
e59f9f4
Compare
Anviking
force-pushed
the
anviking/ADP-3081/move-Redeemer-type
branch
from
e59f9f4
to
53b37d4
Compare
Anviking
commented
Jul 21, 2023
| @@ -223,6 +242,50 @@ assignScriptRedeemers pparams timeTranslation utxo redeemers tx = | |||
| , Just l <- [Alonzo.language script] | |||
| ] | |||
|
|
|||
| -- | |||
| -- The 'Redeemer' type | |||
| -- TODO: Move back to the wallet and/or retire | |||
There was a problem hiding this comment.
👆 We should (probably) work with the redeemers a part of the partial tx CBOR instead. In that case we'd need to add logic for updating the tx without invalidating the existing ix-based pointers.
Anviking
commented
Jul 21, 2023
| ) where | ||
|
|
||
| import Prelude | ||
|
|
||
| import Cardano.Api | ||
| ( StakeAddress, serialiseToBech32 ) |
There was a problem hiding this comment.
Should have the cardano-api imports qualified as Cardano instead.
jonathanknowles
approved these changes
Jul 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Primitive.Types.RedeemersintoWrite.Tx.Redeemers, while avoiding dependency onShelley.CompatibilityComments
Issue Number
ADP-3081