Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ADP-3121] Remove cardano-wallet as dependency from local cluster sublibrary #4097

Merged
merged 10 commits into from
Aug 28, 2023
Merged

[ADP-3121] Remove cardano-wallet as dependency from local cluster sublibrary #4097

merged 10 commits into from
Aug 28, 2023

Conversation

paolino
Copy link
Collaborator

@paolino paolino commented Aug 16, 2023

@paolino paolino self-assigned this Aug 16, 2023
@paolino paolino force-pushed the paolino/ADP-3121/remove-cardano-wallet-dependency-from-cardano-wallet-local-cluster branch 7 times, most recently from 6726d55 to c986457 Compare August 18, 2023 12:15
@paolino paolino force-pushed the paolino/ADP-3121/remove-cardano-wallet-dependency-from-cardano-wallet-local-cluster branch from c986457 to 12d9a3c Compare August 18, 2023 12:18
HeinrichApfelmus
HeinrichApfelmus approved these changes Aug 23, 2023
View reviewed changes
Copy link
Contributor

@HeinrichApfelmus HeinrichApfelmus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent, thank you! 🥳 Minor comments to be addressed before merging.

lib/application-extras/test/Main.hs Outdated Show resolved Hide resolved
lib/wallet/exe/cardano-wallet.hs Outdated Show resolved Hide resolved
lib/wallet/cardano-wallet.cabal Show resolved Hide resolved
lib/wallet/local-cluster/Cardano/Wallet/Faucet.hs Outdated Show resolved Hide resolved
lib/wallet/local-cluster/Cardano/Wallet/Launch/Cluster.hs Outdated Show resolved Hide resolved
@paolino paolino force-pushed the paolino/ADP-3121/remove-cardano-wallet-dependency-from-cardano-wallet-local-cluster branch from 12d9a3c to ba34fd3 Compare August 28, 2023 09:24
@paolino paolino force-pushed the paolino/ADP-3121/remove-cardano-wallet-dependency-from-cardano-wallet-local-cluster branch 2 times, most recently from 586447a to 1d9376c Compare August 28, 2023 09:58
@paolino
Move address encoding functions from Shelley.Compatibility to Address…
0517df8 
….Encoding.

Remove EpochNo types from Cluster module.
@paolino paolino force-pushed the paolino/ADP-3121/remove-cardano-wallet-dependency-from-cardano-wallet-local-cluster branch from 1d9376c to 0517df8 Compare August 28, 2023 11:01
@paolino paolino enabled auto-merge August 28, 2023 11:02
@paolino paolino added this pull request to the merge queue Aug 28, 2023
Merged via the queue into master with commit bdfe092 Aug 28, 2023
2 checks passed
@paolino paolino deleted the paolino/ADP-3121/remove-cardano-wallet-dependency-from-cardano-wallet-local-cluster branch August 28, 2023 12:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HeinrichApfelmus HeinrichApfelmus HeinrichApfelmus approved these changes

Assignees

@paolino paolino

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@paolino @HeinrichApfelmus