Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ADP-3224] Set LOCAL_CLUSTER_CONFIGS to fix unit tests on windows #4284

Merged
merged 5 commits into from
Dec 4, 2023

Conversation

Anviking
Copy link
Member

@Anviking Anviking commented Nov 30, 2023

  • Add cluster-configs to windows testing bundle
  • Set LOCAL_CLUSTER_CONFIGS=test\data\cluster-configs

Issue Number

Failing build: https://github.com/cardano-foundation/cardano-wallet/actions/runs/7044358252/job/19172149072#step:3:7553

Recent passing build from this PR: https://github.com/cardano-foundation/cardano-wallet/actions/runs/7088589000

ADP-3224

@Anviking
Copy link
Member Author

Anviking commented Dec 4, 2023

Unfortunately this didn't work:

https://github.com/cardano-foundation/cardano-wallet/actions/runs/7064294732

  test\unit\Cardano\Wallet\Shelley\NetworkSpec.hs:142:17: 
  2) Cardano.Wallet.Shelley.Network, NetworkLayer regression test #1708, Parallel local socket connections
       uncaught exception: IOException of type NoSuchThing
       ..\local-cluster\test\data\cluster-configs\faucet-addrs: getDirectoryContents:findFirstFile: does not exist (The system cannot find the path specified.)

@HeinrichApfelmus
Copy link
Contributor

Unfortunately this didn't work:

Several options come to mind:

  • The faucet-addrs directory didn't make it into the Windows testing bundle.
  • mkdir — forgot to create intermediate directories using -p.

@Anviking
Copy link
Member Author

Anviking commented Dec 4, 2023

The faucet-addrs directory didn't make it into the Windows testing bundle.

No, it's not there. I wonder if it really used to be 🤔 as opposed to relying on checking out the repo, which however would seem fragile

Skärmavbild 2023-12-04 kl  11 04 03

@Anviking Anviking force-pushed the anviking/windows-unit branch 8 times, most recently from 2fd36f8 to 8d435b9 Compare December 4, 2023 15:11
localClusterConfigsFromEnv = lookupEnvNonEmpty "LOCAL_CLUSTER_CONFIGS"
<&> Tagged @"cluster-configs"
. fromMaybe "../local-cluster/test/data/cluster-configs"
. fromMaybe
(".." </> "local-cluster" </> "test" </> "data" </> "cluster-configs")
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change is now irrelevant to fixing the GH windows unit tests, but it shouldn't hurt. It might be good for people running cabal test on windows after checking the repo out.

@Anviking Anviking changed the title Use </> to attempt to fix windows unit tests Set LOCAL_CLUSTER_CONFIGS to fix unit tests on windows Dec 4, 2023
@Anviking Anviking requested a review from paolino December 4, 2023 15:49
@Anviking Anviking added this pull request to the merge queue Dec 4, 2023
@paolino paolino changed the title Set LOCAL_CLUSTER_CONFIGS to fix unit tests on windows [ADP-3224] Set LOCAL_CLUSTER_CONFIGS to fix unit tests on windows Dec 4, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Dec 4, 2023
@Anviking Anviking added this pull request to the merge queue Dec 4, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Dec 4, 2023
@HeinrichApfelmus HeinrichApfelmus added this pull request to the merge queue Dec 4, 2023
Merged via the queue into master with commit f9c7091 Dec 4, 2023
3 of 4 checks passed
@HeinrichApfelmus HeinrichApfelmus deleted the anviking/windows-unit branch December 4, 2023 17:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants