Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ADP-3224] Remove unacceptable e2e tests #4325

Merged
merged 1 commit into from
Dec 11, 2023

Conversation

paolino
Copy link
Collaborator

@paolino paolino commented Dec 11, 2023

  • Relax expectations used in the E2E tests that are too strict (and therefore fragile): they fail to take into account a possibility of an epoch boundary happening between registering a stake key delegation and un-registering it.

@paolino paolino self-assigned this Dec 11, 2023
As unreliable if between joining and leaving pools we cross epoch boundary
@paolino paolino force-pushed the paolino/ADP-3224/remove-unacceptable-e2e-tests branch from 814d661 to fda940c Compare December 11, 2023 15:12
Base automatically changed from paolino/ADP-3224/hard-code-node-8.1.2-e2e-genesis-files to master December 11, 2023 15:51
@paolino paolino marked this pull request as ready for review December 11, 2023 16:47
@paolino paolino requested a review from Unisay December 11, 2023 16:48
@Unisay Unisay added this pull request to the merge queue Dec 11, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Dec 11, 2023
@Unisay Unisay added this pull request to the merge queue Dec 11, 2023
Merged via the queue into master with commit 752c8b2 Dec 11, 2023
4 of 6 checks passed
@Unisay Unisay deleted the paolino/ADP-3224/remove-unacceptable-e2e-tests branch December 11, 2023 17:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants