Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ADP-3224] Change 'token' to 'assetName' in E2E expectations #4343

Merged
merged 1 commit into from
Dec 14, 2023

Conversation

paolino
Copy link
Collaborator

@paolino paolino commented Dec 14, 2023

  • changed token into assetName in the E2E expectations in some error messages
  • add cardano-cli to the E2E nix shell to allow running tests locally

Fixes https://github.com/cardano-foundation/cardano-wallet/actions/runs/7208803096/job/19638494587#step:12:926

ADP-3224

@paolino paolino self-assigned this Dec 14, 2023
Copy link
Contributor

@HeinrichApfelmus HeinrichApfelmus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Thank you!

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Huh, this file appears to be very much a leftover from before flake.nix days. We may want to integrate it into the flake — but not today.

@paolino paolino force-pushed the paolino/ADP-3224/fix-E2E-error-message-expectation branch from 11689d5 to e9f0d02 Compare December 14, 2023 17:09
@paolino paolino added this pull request to the merge queue Dec 14, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Dec 14, 2023
@paolino paolino added this pull request to the merge queue Dec 14, 2023
Merged via the queue into master with commit b8e1f90 Dec 14, 2023
4 checks passed
@paolino paolino deleted the paolino/ADP-3224/fix-E2E-error-message-expectation branch December 14, 2023 18:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants