Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix e2e "currency" test #4578

Merged
merged 2 commits into from
May 6, 2024
Merged

Conversation

Anviking
Copy link
Member

@Anviking Anviking commented May 3, 2024

  • Alleviate the following failure in the e2e tests
1) Cardano Wallet E2E tests E2E Balance -> Sign -> Submit currency
     Failure/Error: input = coin_selection['inputs'].select { |i| i['assets'] == [] }.first

     NoMethodError:
       private method `select' called for nil:NilClass

             input = coin_selection['inputs'].select { |i| i['assets'] == [] }.first
                                             ^^^^^^^
     # ./spec/e2e_spec.rb:476:in `block (3 levels) in <top (required)>'

by making it easier to find an UTxO from the wallet.

New (about to be) passing run: https://github.com/cardano-foundation/cardano-wallet/actions/runs/8943585972

Debug details

UTxO ada amounts of wallet associated with test failure

https://preprod.cexplorer.io/address/addr_test1qp9juu544jrkel0hp6pvrjud70h9ev3ajw2fuvezyv8ug3eg3292mxuf3kq7nysjumlxjrlsfn9tp85r0l54l29x3qcsytvx58/utxo#data

[
  24.08152,
  24.08152,
  24.08152,
  24.08152,
  24.08152,
  24.08152,
  24.08152,
  24.08152,
  24.08152,
  24.08152,
  24.08152,
  24.08152,
  24.08152,
  10,
  10,
  24.08152,
  24.08152,
  10,
  24.08152,
  24.08152,
  10,
  10,
  10,
  24.08152,
  10,
  24.08152,
  10,
  24.08152,
  24.08152,
  10,
  24.08152,
  24.08152,
  10,
  10,
  24.08152,
  24.08152,
  10,
  10,
  10,
  24.08152,
  10,
  24.08152,
  10,
  24.08152,
  10,
  10,
  24.08152,
  10,
  10,
  10,
  24.08152,
  10,
  10,
  10,
  10,
  10,
  10,
  10,
  10,
  24.08152,
  10,
  10,
  10,
  10,
  24.08152,
  10,
  10,
  10,
  10,
  10,
  10,
  10,
  24.08152,
  10,
  10,
  10,
  10,
  10,
  10,
  10,
  10,
  24.08152,
  10,
  10,
  10,
  10,
  10,
  10,
  24.08152,
  10,
  10,
  10,
  10,
  10,
  10,
  10,
  10,
  10,
  10,
  10,
  10,
  10,
  10,
  10,
  10,
  10,
  10,
  10
]

Issue Number

ADP-3358

@Anviking Anviking self-assigned this May 3, 2024
@Anviking Anviking force-pushed the anviking/ADP-3358/fix-e2e-currency branch from 162ee74 to 8868e54 Compare May 3, 2024 18:53
@Anviking Anviking marked this pull request as ready for review May 3, 2024 19:00
Copy link
Collaborator

@paolino paolino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@Anviking Anviking added this pull request to the merge queue May 6, 2024
Merged via the queue into master with commit 2dc4daf May 6, 2024
5 checks passed
@Anviking Anviking deleted the anviking/ADP-3358/fix-e2e-currency branch May 6, 2024 09:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants