Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ADP-3226] drop tests that assume port 8090 is unbound on the host #4634

Conversation

paolino
Copy link
Collaborator

@paolino paolino commented Jun 17, 2024

This PR remove a set of tests that assume port 8090 is free on the host where the wallet is running. It's not always the case on CI machine.

ADP-3226

@paolino paolino added Bug CI CI related labels Jun 17, 2024
@paolino paolino self-assigned this Jun 17, 2024
@paolino paolino force-pushed the paolino/ADP-3226/drop-tests-that-assume-port-8090-is-unbound-on-the-host branch 2 times, most recently from 58b0d36 to f09471e Compare June 17, 2024 09:28
@paolino paolino force-pushed the paolino/ADP-3226/drop-tests-that-assume-port-8090-is-unbound-on-the-host branch from f09471e to a060eab Compare June 17, 2024 09:31
Copy link
Contributor

@paweljakubas paweljakubas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks reasonable

@paolino paolino enabled auto-merge June 17, 2024 10:02
@paolino paolino added this pull request to the merge queue Jun 17, 2024
@paolino paolino removed this pull request from the merge queue due to a manual request Jun 17, 2024
@paolino paolino added this pull request to the merge queue Jun 17, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to no response for status checks Jun 17, 2024
@paolino paolino force-pushed the paolino/ADP-3226/drop-tests-that-assume-port-8090-is-unbound-on-the-host branch from 27a628f to a060eab Compare June 17, 2024 12:05
@paolino paolino enabled auto-merge June 17, 2024 12:06
@paolino paolino added this pull request to the merge queue Jun 17, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jun 17, 2024
@paolino paolino added this pull request to the merge queue Jun 17, 2024
Merged via the queue into master with commit c9feed4 Jun 17, 2024
5 checks passed
@paolino paolino deleted the paolino/ADP-3226/drop-tests-that-assume-port-8090-is-unbound-on-the-host branch June 17, 2024 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug CI CI related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants