Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ADP-3368] Move docker e2e tests to buildkite release pipeline #4658

Merged
merged 8 commits into from
Jul 3, 2024
Merged

[ADP-3368] Move docker e2e tests to buildkite release pipeline #4658

merged 8 commits into from
Jul 3, 2024

Conversation

paolino
Copy link
Collaborator

@paolino paolino commented Jun 28, 2024 •
edited
Loading

  • Enable docker compose smoke test in release pipeline
  • Fix docker-compose to allow $UID control
  • Make sure we do not create release-candidate branches when not forking from master
  • Group steps by OS in release pipeline
  • Add socket filepath control to work around unix named pipe length limitation

ADP-3368

@paolino paolino added CI CI related Release labels Jun 28, 2024
@paolino paolino self-assigned this Jun 28, 2024
@paolino paolino force-pushed the paolino/ADP-3368/move-docker-E2E-tests branch 9 times, most recently from 62318f1 to c6d795a Compare June 28, 2024 16:48
Base automatically changed from paolino/ADP-3368/move-linux-E2E-test-to-buildkite to master June 28, 2024 17:58
@paolino paolino force-pushed the paolino/ADP-3368/move-docker-E2E-tests branch 17 times, most recently from 7dfd7f1 to 79ffaa5 Compare June 28, 2024 22:24
@paolino paolino force-pushed the paolino/ADP-3368/move-docker-E2E-tests branch 8 times, most recently from 5db5ffa to 2e45678 Compare July 2, 2024 13:40
@HeinrichApfelmus HeinrichApfelmus force-pushed the HeinrichApfelmus/ADP-3368/macos-e2e branch from 2b005fd to 0d981b3 Compare July 2, 2024 15:06
@HeinrichApfelmus HeinrichApfelmus mentioned this pull request Jul 2, 2024
Merged
1 task
Base automatically changed from HeinrichApfelmus/ADP-3368/macos-e2e to master July 2, 2024 16:56
@paolino paolino force-pushed the paolino/ADP-3368/move-docker-E2E-tests branch 2 times, most recently from ebbd3ba to d53023a Compare July 3, 2024 10:23
@paolino paolino marked this pull request as ready for review July 3, 2024 10:25
HeinrichApfelmus
HeinrichApfelmus approved these changes Jul 3, 2024
View reviewed changes
Copy link
Contributor

@HeinrichApfelmus HeinrichApfelmus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! 😊 One issue with NODE_TAG, and a minor comment on key of the docker compose step.

.buildkite/release.yml Outdated Show resolved Hide resolved
.buildkite/release.yml Outdated Show resolved Hide resolved
scripts/buildkite/release/docker-build.sh Outdated Show resolved Hide resolved
scripts/buildkite/release/docker-smoke-test.sh Outdated Show resolved Hide resolved
@paolino paolino force-pushed the paolino/ADP-3368/move-docker-E2E-tests branch 2 times, most recently from 83fbd29 to f73d569 Compare July 3, 2024 16:21
@paolino paolino enabled auto-merge July 3, 2024 16:35
@paolino paolino added this pull request to the merge queue Jul 3, 2024
Merged via the queue into master with commit 603845c Jul 3, 2024
3 checks passed
@paolino paolino deleted the paolino/ADP-3368/move-docker-E2E-tests branch July 3, 2024 17:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HeinrichApfelmus HeinrichApfelmus HeinrichApfelmus approved these changes

Assignees

@paolino paolino

Labels
CI CI related Release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@paolino @HeinrichApfelmus