Manually tweak e2e fixtures to be valid in Conway #4752
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Anviking
force-pushed
the
anviking/ADP-3413/e2e-game-fixtures-conway
branch
from
b1bd20e
to
83b01b9
Compare
|
Doh, classic editing the wrong file 😅 |
Anviking
force-pushed
the
anviking/ADP-3413/e2e-game-fixtures-conway
branch
4 times, most recently
from
11cc375
to
0cf78dd
Compare
|
@paolino e2e test pass (albeit with one pending). Ruby linter fails, but it doesn't look related to the one line I added. Please review and merge if you see fit. |
Anviking
force-pushed
the
anviking/ADP-3413/e2e-game-fixtures-conway
branch
from
0cf78dd
to
ff7f9ee
Compare
Anviking
changed the title
HeinrichApfelmus
approved these changes
Sep 2, 2024
When reproducing in a unit test I got the following two failures: - DecoderErrorDeserialiseFailure "Shelley Tx" (DeserialiseFailure 117 "TxBody: 'Required Signer Hashes' must be non-empty when supplied") - DecoderErrorDeserialiseFailure "Shelley Tx" (DeserialiseFailure 42 "TxBody: 'Collateral Inputs' must be non-empty when supplied") These correspond to the tags 13 and 14 in the Conway binary spec: https://github.com/IntersectMBO/cardano-ledger/blob/8d7d261dfb6282ab86cad32ec3f1be71db9a3080/eras/conway/impl/cddl-files/conway.cddl#L431-L432 Using cbor.me we can confirm the presence of in the binaries from the errors: ``` 0D # unsigned(13) 80 # array(0) ``` So we manaully delete - `0d80` - `0e80` with this meaning (some matches of 0e80 were part of bytestrings, so we don't delete them) And then adjust the preceding TxBody length: ``` 84 # array(4) A5 # map(5) ``` E.g. `s/A5/A3`.
HeinrichApfelmus
force-pushed
the
anviking/ADP-3413/e2e-game-fixtures-conway
branch
from
e90f8f2
to
c24f835
Compare
HeinrichApfelmus
deleted the
anviking/ADP-3413/e2e-game-fixtures-conway
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Comments
When reproducing in a unit test I got the following two failures:
These correspond to the tags 13 and 14 in the Conway binary spec:
https://github.com/IntersectMBO/cardano-ledger/blob/8d7d261dfb6282ab86cad32ec3f1be71db9a3080/eras/conway/impl/cddl-files/conway.cddl#L431-L432
Using cbor.me we can confirm the presence of in the binaries from the
errors:
So we manaully delete
0d800e80with this meaning (some matches of 0e80 were part of bytestrings, so we
don't delete them)
And then adjust the preceding TxBody length:
E.g.
s/A5/A3.Issue Number
ADP-3413