-
Notifications
You must be signed in to change notification settings - Fork 213
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ADP-3437] Use REST interface in data API to create the deposit wallet #4782
Merged
paolino
merged 14 commits into
master
from
paolino/ADP-3437/use-REST-interface-indata-API-for-deposit-wallet
Sep 25, 2024
Merged
[ADP-3437] Use REST interface in data API to create the deposit wallet #4782
paolino
merged 14 commits into
master
from
paolino/ADP-3437/use-REST-interface-indata-API-for-deposit-wallet
Sep 25, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paolino
changed the title
[ADP-3437] Use Rest interface in json api to create the deposit wallet
[ADP-3437] Use REST interface in data API to create the deposit wallet
Sep 19, 2024
Base automatically changed from
paolino/ADP-3435/add-deposit-wallet-deletion-UI
to
master
September 19, 2024 15:24
paolino
force-pushed
the
paolino/ADP-3437/use-REST-interface-indata-API-for-deposit-wallet
branch
2 times, most recently
from
September 20, 2024 15:53
eeabf43
to
89c0906
Compare
paolino
force-pushed
the
paolino/ADP-3437/use-REST-interface-indata-API-for-deposit-wallet
branch
3 times, most recently
from
September 23, 2024 07:58
0743527
to
52c2666
Compare
HeinrichApfelmus
approved these changes
Sep 25, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Excellent, thank you! 😊
lib/customer-deposit-wallet/rest/Cardano/Wallet/Deposit/REST/Wallet/Create.hs
Outdated
Show resolved
Hide resolved
lib/customer-deposit-wallet/rest/Cardano/Wallet/Deposit/REST/Wallet/Create.hs
Outdated
Show resolved
Hide resolved
paolino
force-pushed
the
paolino/ADP-3437/use-REST-interface-indata-API-for-deposit-wallet
branch
from
September 25, 2024 15:37
52c2666
to
6dae991
Compare
paolino
force-pushed
the
paolino/ADP-3437/use-REST-interface-indata-API-for-deposit-wallet
branch
from
September 25, 2024 15:42
6dae991
to
6cc17f0
Compare
…om the ui to be reused in json http
…eposit.HTTP.server
Now loading is taken care of outside the server, in Application module in the exe package
paolino
force-pushed
the
paolino/ADP-3437/use-REST-interface-indata-API-for-deposit-wallet
branch
from
September 25, 2024 15:47
6cc17f0
to
3bd64ee
Compare
paolino
deleted the
paolino/ADP-3437/use-REST-interface-indata-API-for-deposit-wallet
branch
September 25, 2024 18:19
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ADP-3437