Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ADP-3454] Have smooth data swapping in UI #4784

Merged
merged 11 commits into from
Sep 26, 2024
Merged

[ADP-3454] Have smooth data swapping in UI #4784

merged 11 commits into from
Sep 26, 2024

Conversation

paolino
Copy link
Collaborator

@paolino paolino commented Sep 23, 2024

This PR remove some ghost appearance of old things during data swapping in the deposit UI

ADP-3454

@paolino paolino added Deposit UI UI related changes labels Sep 23, 2024
@paolino paolino self-assigned this Sep 23, 2024
@paolino paolino force-pushed the paolino/ADP-3454/smooth-data-swapping-in-UI branch from 68f50d9 to e37ea43 Compare September 23, 2024 11:10
HeinrichApfelmus
HeinrichApfelmus approved these changes Sep 25, 2024
View reviewed changes
Copy link
Contributor

@HeinrichApfelmus HeinrichApfelmus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👻 😊

@paolino paolino force-pushed the paolino/ADP-3451/use-a-single-thread-to-signal-resource-changes branch from 0743527 to 4e40603 Compare September 25, 2024 16:04
@paolino paolino force-pushed the paolino/ADP-3454/smooth-data-swapping-in-UI branch from e37ea43 to 8da237e Compare September 25, 2024 16:05
@paolino paolino force-pushed the paolino/ADP-3451/use-a-single-thread-to-signal-resource-changes branch from 4e40603 to 2b3f154 Compare September 25, 2024 16:13
@paolino paolino force-pushed the paolino/ADP-3454/smooth-data-swapping-in-UI branch from 8da237e to 09cedfb Compare September 25, 2024 16:25
Base automatically changed from paolino/ADP-3451/use-a-single-thread-to-signal-resource-changes to master September 25, 2024 19:47
@paolino
[ADP-3455] Compact up navigation on small screens (#4785)
7b410a0 
This PR makes space for the navigation on small screens by having a
foldable navigation bar. It also remove the footer everywhere but on the
about page.

ADP-3455
@paolino
[ADP-3457] Optimize layout (#4786)
d5544e5 
This PR makes the UI usable on big screen just by limiting the width and
fix content justification on values of associations.

ADP-3457
@paolino
[ADP-3450] Fix copy buttons on mobile. (#4787)
f5328e4 
This PR fixes the copy issues on mobile by using the clipboard.js
library. Also use a standard icon on the copy button

ADP-3450
@paolino paolino added this pull request to the merge queue Sep 26, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Sep 26, 2024
@paolino paolino merged commit cc68d3f into master Sep 26, 2024
22 checks passed
@paolino paolino deleted the paolino/ADP-3454/smooth-data-swapping-in-UI branch September 26, 2024 07:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HeinrichApfelmus HeinrichApfelmus HeinrichApfelmus approved these changes

Assignees

@paolino paolino

Labels
Deposit UI UI related changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@paolino @HeinrichApfelmus