Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ADP-3344] Use Read.Block instead of mock Block type in Deposit Wallet #4802

Merged
merged 2 commits into from
Oct 1, 2024
Merged

[ADP-3344] Use Read.Block instead of mock Block type in Deposit Wallet #4802

merged 2 commits into from
Oct 1, 2024

Conversation

HeinrichApfelmus
Copy link
Contributor

This pull request replaces the mock Block type in the Deposit Wallet with the real thing, Read.Block.

Comments

  • After this pull request, we can connect the Deposit Wallet to a local cluster.
  • In order to connect to one of the public test networks, we need to implement the Testnet tag in Address.

Issue number

ADP-3344

@HeinrichApfelmus HeinrichApfelmus self-assigned this Sep 30, 2024
@HeinrichApfelmus HeinrichApfelmus changed the title Use Read.Block instead of mock Block type in Deposit Wallet [ADP-3344] Use Read.Block instead of mock Block type in Deposit Wallet Sep 30, 2024
@HeinrichApfelmus HeinrichApfelmus force-pushed the HeinrichApfelmus/ADP-3344/real-block branch from af816c3 to b933d8f Compare October 1, 2024 11:00
@HeinrichApfelmus HeinrichApfelmus force-pushed the HeinrichApfelmus/ADP-3344/real-block branch from b933d8f to 9b2fd9e Compare October 1, 2024 12:12
@HeinrichApfelmus HeinrichApfelmus marked this pull request as ready for review October 1, 2024 12:14
paolino
paolino approved these changes Oct 1, 2024
View reviewed changes
Copy link
Collaborator

@paolino paolino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@HeinrichApfelmus HeinrichApfelmus added this pull request to the merge queue Oct 1, 2024
Merged via the queue into master with commit 66e819c Oct 1, 2024
26 checks passed
@HeinrichApfelmus HeinrichApfelmus deleted the HeinrichApfelmus/ADP-3344/real-block branch October 1, 2024 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@paolino paolino paolino approved these changes

Assignees

@HeinrichApfelmus HeinrichApfelmus

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@HeinrichApfelmus @paolino