[ADP-3344] Split off Cardano.Write.Eras
#4809
Conversation
HeinrichApfelmus
force-pushed
the
HeinrichApfelmus/ADP-3344/write-era
branch
3 times, most recently
from
b513018
to
ee6010b
Compare
HeinrichApfelmus
changed the title
Cardano.Write.ErasCardano.Write.Eras
HeinrichApfelmus
force-pushed
the
HeinrichApfelmus/ADP-3344/write-era
branch
3 times, most recently
from
84d286b
to
16d3218
Compare
HeinrichApfelmus
force-pushed
the
HeinrichApfelmus/ADP-3344/write-era
branch
from
16d3218
to
b1110a5
Compare
| module Cardano.Write.Eras | ||
| ( | ||
| -- * Eras | ||
| BabbageEra | ||
| , ConwayEra | ||
|
|
||
| -- ** RecentEra | ||
| , RecentEra (..) | ||
| , IsRecentEra (..) | ||
| , CardanoApiEra | ||
| , toRecentEra | ||
| , fromRecentEra | ||
| , MaybeInRecentEra (..) | ||
| , LatestLedgerEra | ||
| , RecentEraConstraints | ||
| , allRecentEras | ||
|
|
||
| -- ** Existential wrapper | ||
| , AnyRecentEra (..) | ||
| , toAnyCardanoEra | ||
| , fromAnyCardanoEra | ||
|
|
||
| -- ** Helpers for cardano-api compatibility | ||
| , cardanoEra | ||
| , shelleyBasedEra | ||
| , ShelleyLedgerEra | ||
| , cardanoEraFromRecentEra | ||
| , shelleyBasedEraFromRecentEra | ||
| ) where | ||
|
|
||
| import Internal.Cardano.Write.Eras | ||
| ( AnyRecentEra (..) | ||
| , BabbageEra | ||
| , CardanoApiEra | ||
| , ConwayEra | ||
| , IsRecentEra (..) | ||
| , LatestLedgerEra | ||
| , MaybeInRecentEra (..) | ||
| , RecentEra (..) | ||
| , RecentEraConstraints | ||
| , ShelleyLedgerEra | ||
| , allRecentEras | ||
| , cardanoEra | ||
| , cardanoEraFromRecentEra | ||
| , fromAnyCardanoEra | ||
| , fromRecentEra | ||
| , shelleyBasedEra | ||
| , shelleyBasedEraFromRecentEra | ||
| , toAnyCardanoEra | ||
| , toRecentEra | ||
| ) |
There was a problem hiding this comment.
I'm not too fond of duplicating this interface (friction to change, risk of sections getting out of sync etc), but we can go with it for now
There was a problem hiding this comment.
Yes. The idea is that the public interface, that is Cardano.Write.Eras, is the source of truth that we need to curate, and that Internal.Cardano.Write.Eras is an internal module that we can arrange as we please, including removal. For the time being, I'd like to invest into curation and avoid upsetting the internal arrangement of balance-tx too much.
I think the original idea behind the :internal sublibrary was that the public library can choose not to export certain internals, such as constructors for abstract data types, but that these internals are still available when unit testing the internal library.
There was a problem hiding this comment.
For the time being, I'd like to invest into curation and avoid upsetting the internal arrangement of balance-tx too much.
👍
This pull requests splits off a public module
Cardano.Write.Erasfor working with the notion of "recent era".First, we split off an internal module, then we create a public module that re-exports the internal module.
Comments
Cardano.Write.Erasyet.Issue Number
ADP-3344