Skip to content
This repository has been archived by the owner on Dec 10, 2024. It is now read-only.

fix: display protocol data #3107

Merged
merged 5 commits into from
Mar 6, 2024
Merged

Conversation

tungnguyendinh
Copy link
Collaborator

Description

fix: display protocol data

Checklist before requesting a review

Issue ticket number and link

  • This PR has a valid ticket number or issue: [link]

Testing & Validation

  • This PR has been tested/validated in Chrome, Firefox, Safari and Brave browsers.
  • The code has been tested locally with test coverage match expectations.
  • Added new Unit/Component testing (if relevant).

Security

  • No secrets are being committed (i.e. credentials, PII)
  • This PR does not have any significant security implications

Code Review

  • There is no unused functionality or blocks of commented out code (otherwise, please explain below)
  • In addition to this PR, all relevant documentation (e.g. Confluence / README.md file) and architecture diagrams (e.g. Miro) were updated

Design Review

  • If this PR contains changes to the UI, it has gone through a design review with UX Designer or Product owner.
  • In case PR contains changes to the UI, add some screenshots to notice the differences

Chrome

Before
After

Safari

Before
After

Responsive

Before
After

@tungnguyendinh tungnguyendinh added hold Hold 1.0.0 For sprint 10 (P3 - sprint 5) and more labels Mar 4, 2024
@tungnguyendinh tungnguyendinh removed the hold Hold label Mar 5, 2024
@tungnguyendinh tungnguyendinh marked this pull request as ready for review March 5, 2024 11:24
@Sotatek-TaiTruong Sotatek-TaiTruong merged commit 27edadd into 1.0.0 Mar 6, 2024
4 of 9 checks passed
@Sotatek-TaiTruong Sotatek-TaiTruong deleted the fix/display-protocol-data branch March 8, 2024 09:49
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
1.0.0 For sprint 10 (P3 - sprint 5) and more
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants