Skip to content
This repository was archived by the owner on Dec 10, 2024. It is now read-only.

fix: repalce Modal from modal in MUI to modal in common #4112

Conversation

tungnguyendinh
Copy link
Collaborator

Description

Please include a summary of the changes and a brief description about this PR

Checklist before requesting a review

Issue ticket number and link

  • This PR has a valid ticket number or issue: [link]

Testing & Validation

  • This PR has been tested/validated in Chrome, Firefox, Safari and Brave browsers.
  • The code has been tested locally with test coverage match expectations.
  • Added new Unit/Component testing (if relevant).

Security

  • No secrets are being committed (i.e. credentials, PII)
  • This PR does not have any significant security implications

Code Review

  • There is no unused functionality or blocks of commented out code (otherwise, please explain below)
  • In addition to this PR, all relevant documentation (e.g. Confluence / README.md file) and architecture diagrams (e.g. Miro) were updated

Design Review

  • If this PR contains changes to the UI, it has gone through a design review with UX Designer or Product owner.
  • In case PR contains changes to the UI, add some screenshots to notice the differences

Chrome

Before
After

Safari

Before
After

Responsive

Before
After

@tungnguyendinh tungnguyendinh changed the title fix: repalce from modal MUI to modal common fix: repalce Modal from modal in MUI to modal common Nov 18, 2024
@tungnguyendinh tungnguyendinh changed the title fix: repalce Modal from modal in MUI to modal common fix: repalce Modal from modal in MUI to modal in common Nov 18, 2024
@Sotatek-TaiTruong Sotatek-TaiTruong merged commit 86bacf0 into dev-test Nov 18, 2024
2 checks passed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants