PR review comments

cardano-scaling · Nov 11, 2024 · 42eef1a · 42eef1a
1 parent 2527497
commit 42eef1a
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 6 deletions.
diff --git a/hydra-cluster/src/Hydra/Cluster/Scenarios.hs b/hydra-cluster/src/Hydra/Cluster/Scenarios.hs
@@ -110,7 +110,6 @@ import Network.HTTP.Req (
  )
 import Network.HTTP.Simple (getResponseBody, httpJSON, setRequestBodyJSON)
 import Network.HTTP.Types (urlEncode)
-import PlutusLedgerApi.Test.Examples (alwaysSucceedingNAryFunction)
 import System.Directory (removeDirectoryRecursive)
 import System.FilePath ((</>))
 import Test.Hydra.Tx.Fixture (testNetworkId)

diff --git a/hydra-node/test/Hydra/Chain/Direct/TxSpec.hs b/hydra-node/test/Hydra/Chain/Direct/TxSpec.hs
@@ -288,7 +288,7 @@ genBlueprintTxWithUTxO =
       [ pure (utxo, txbody)
       , do
           lovelace <- arbitrary
-          let redeemer = toScriptData ()
+          let redeemer = arbitrary `generateWith` 42
               alwaysSucceedingScript = PlutusScriptSerialised dummyValidatorScript
               scriptWitness = mkScriptWitness alwaysSucceedingScript NoScriptDatumForStake redeemer
               stakeAddress = mkScriptStakeAddress testNetworkId alwaysSucceedingScript

diff --git a/hydra-tx/test/Hydra/Tx/Contract/Commit.hs b/hydra-tx/test/Hydra/Tx/Contract/Commit.hs
@@ -127,8 +127,8 @@ genCommitMutation (tx, _utxo) =
                   (party, mCommit, toPlutusCurrencySymbol otherHeadId)
         pure $ ChangeOutput 0 $ mutateHeadId commitTxOut
     , SomeMutation (pure $ toErrorCode LockedValueDoesNotMatch) MutateCommitOutputValue . ChangeOutput 0 <$> do
-        mutatedValue <- scale (`div` 2) genValue `suchThat` (/= commitOutputValue)
-        pure $ commitTxOut{txOutValue = mutatedValue <> negateValue mutatedValue}
+        let totalValueMinusOneLovelace = negateValue (lovelaceToValue 1) <> txOutValue healthyInitialTxOut <> foldMap (txOutValue . snd) (UTxO.pairs healthyCommittedUTxO)
+        pure $ commitTxOut{txOutValue = totalValueMinusOneLovelace}
     , SomeMutation (pure $ toErrorCode LockedValueDoesNotMatch) MutateCommittedValue <$> do
         mutatedValue <- scale (`div` 2) genValue `suchThat` (/= aCommittedOutputValue)
         let mutatedOutput = modifyTxOutValue (const mutatedValue) aCommittedTxOut
@@ -169,8 +169,6 @@ genCommitMutation (tx, _utxo) =
         <$> (changeMintedTokens tx =<< genMintedOrBurnedValue)
     ]
  where
-  TxOut{txOutValue = commitOutputValue} = commitTxOut
-
   commitTxOut = fromJust $ txOuts' tx !!? 0
 
   allComittedTxIn = UTxO.inputSet healthyCommittedUTxO & toList