Squash warning after embed-resource version bump; enable clippy in ci (…

…#321)

* run clippy in ci

* fix clippy lint in stats-server project

* squash warning in client project after embed_resource version bump

* use working_directory option rather than cd

Co-authored-by: Jiahao XU <30436523+NobodyXu@users.noreply.github.com>
Signed-off-by: David Laban <alsuren@gmail.com>

---------

Signed-off-by: David Laban <alsuren@gmail.com>
Co-authored-by: Jiahao XU <30436523+NobodyXu@users.noreply.github.com>

.github/workflows/test.yml

@@ -52,6 +52,13 @@ jobs:
       - name: Fetch tags required for testing
         run: git fetch --tags
 
+      - name: Run cargo clippy for client project
+        run: cargo clippy --all-targets --all-features -- -D warnings
+
+      - name: Run cargo clippy for stats-server project
+        run: cargo clippy --all-targets --all-features -- -D warnings
+        working-directory: stats-server
+
       - name: Run cargo test
         run: cargo test
 

cargo-quickinstall/build.rs

@@ -3,5 +3,7 @@ fn main() {
     println!("cargo:rerun-if-changed=manifest.rc");
     println!("cargo:rerun-if-changed=windows.manifest");
 
-    embed_resource::compile("manifest.rc", embed_resource::NONE);
+    embed_resource::compile("manifest.rc", embed_resource::NONE)
+        .manifest_required()
+        .unwrap();
 }

stats-server/src/main.rs

@@ -53,7 +53,7 @@ async fn root() -> &'static str {
 }
 
 fn get_env(key: &str) -> String {
-    std::env::var(key).expect(&format!("{key} must be set"))
+    std::env::var(key).unwrap_or_else(|_| panic!("{key} must be set"))
 }
 
 async fn redirect_to_root() -> Redirect {